Benchmarks + SlugHelperImproved #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix whitespace cleaning tests * Add test for double replace * Create a new helper each time * Use a dictionary for caching denied character regexes * Cache the default config * Whitespace and usings cleanup * Lazily cache the cleanup regex * Trim and lowercase string without allocating * Collapse whitespace without allocating * Apply string replacements without allocating * Remove bad test * Add more coverage for string replacements * Fix string replacement bugs * Replace RemoveDiacritics with a non-allocating version * Add test for whitespace in a string replacement from @Buildstarted * Don't use regexes for denied characters by default * Update tests for allowed characters * Add test for legacy behaviour * Dont regress legacy benchmarks * Process allowed characters * Collapse dashes without allocating * Cache IsWhitespace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.