Merge pull request #22 from larskn/bugfix/denied-characters-regex-alw…

…ays-empty-result Fixed issue where result was always empty if DeniedCharactersRegex was set.
ctolkien · Nov 1, 2021 · 9c1e3dc · 9c1e3dc
2 parents 113adfc + 8886aeb
commit 9c1e3dc
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/src/Slugify.Core/SlugHelper.cs b/src/Slugify.Core/SlugHelper.cs
@@ -46,8 +46,9 @@ public string GenerateSlug(string inputString)
                     _deleteRegexMap.Add(Config.DeniedCharactersRegex, deniedCharactersRegex);
                 }
 
+                var currentValue = sb.ToString();
                 sb.Clear();
-                sb.Append(DeleteCharacters(sb.ToString(), deniedCharactersRegex));
+                sb.Append(DeleteCharacters(currentValue, deniedCharactersRegex));
             }
 
             if (Config.CollapseDashes)

diff --git a/tests/Slugify.Core.Tests/SlugHelperTests.cs b/tests/Slugify.Core.Tests/SlugHelperTests.cs
@@ -143,6 +143,21 @@ public void TestDeniedCharacterDeletionLegacy()
             Assert.Equal(expected, helper.GenerateSlug(original));
         }
 
+
+        [Fact]
+        public void TestDeniedCharacterDeletionLegacyKeepsAllowedCharacters()
+        {
+            const string original = "Abc-123.$1$_x";
+            const string expected = "abc-123.1_x";
+
+            var helper = Create(new SlugHelperConfiguration
+            {
+                DeniedCharactersRegex = @"[^a-zA-Z0-9\-\._]"
+            });
+
+            Assert.Equal(expected, helper.GenerateSlug(original));
+        }
+
         [Fact]
         public void TestCharacterReplacementWithWhitespace()
         {