Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SQL for getting activities by target #8

Merged
merged 4 commits into from
Oct 29, 2022
Merged

Add SQL for getting activities by target #8

merged 4 commits into from
Oct 29, 2022

Conversation

cthoyt
Copy link
Owner

@cthoyt cthoyt commented Oct 29, 2022

This PR adds some functionality for generating target-based datasets, motivated by PatWalters/yamc#14.

See the notebook here (note that this is pinned with a permalink to the state after merging this PR).

@codecov-commenter
Copy link

codecov-commenter commented Oct 29, 2022

Codecov Report

Merging #8 (14a86f8) into main (bbe029e) will decrease coverage by 3.92%.
The diff coverage is 2.56%.

@@            Coverage Diff             @@
##             main       #8      +/-   ##
==========================================
- Coverage   29.01%   25.09%   -3.93%     
==========================================
  Files           5        6       +1     
  Lines         224      263      +39     
  Branches       54       61       +7     
==========================================
+ Hits           65       66       +1     
- Misses        156      194      +38     
  Partials        3        3              
Impacted Files Coverage Δ
src/chembl_downloader/contrib.py 0.00% <0.00%> (ø)
src/chembl_downloader/queries.py 73.33% <50.00%> (-3.59%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cthoyt cthoyt changed the title Add target getter Add SQL for getting activities by target Oct 29, 2022
@cthoyt cthoyt merged commit a68bef1 into main Oct 29, 2022
@cthoyt cthoyt deleted the add-target-getter branch October 29, 2022 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants