Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gamma integration #11

Merged
merged 26 commits into from
Jul 6, 2020
Merged

Gamma integration #11

merged 26 commits into from
Jul 6, 2020

Conversation

molleer
Copy link
Member

@molleer molleer commented Jun 30, 2020

No description provided.

molleer added 24 commits May 20, 2020 18:20
@molleer
Added gamma docker-compose
b7db1b8
@molleer
Created scelleton for gamma provider
b50e7b8
@molleer
Fetchin key and url from config file
78eb875
@molleer
Started implementing the gamma provider with gamma
a1a741c
@molleer
The gamma provider fetches all super groups and groups from gamma
62cd5fa
@molleer
GammaService returns active users which has completed GDPR
84a794b
@molleer
Added post mails and fixed bugs
bf04758
@molleer
Users of active committees has @chalmers.it mails and there are not d…
978e538 
…uplicates
@molleer
Refactored the gamma service
42c6f58
@molleer
Added error messages
01f07ce
@molleer
Created tests for the most important functions
9c5695e
@molleer
Extracting groups by using NormalGroupList and SuperGroupList
5ec46e9
@molleer
Passing pointers instead of copying values
26fcdfe
@molleer
Implemented change to pointers
8d9fa6c
@molleer
Added kit mail
b3b3295
@molleer
Gives postmail to all groups, fixed small bugs
869c2ba
@molleer
Changed kit to kommitteer and fkit to grupper
0f55547
@molleer
Empty mail groups are removed. If a super group is empty, ita.styri@c…
a7b6cb7 
…halmers.it will be added
@molleer
Created test for empty super group
23a1e18
@molleer
Using the list logic for collecting post mails
ca23732
@molleer
Added groups ordforanden, kassorer etc
3fd5c64
@molleer
Removed old post-mail logic
45c2eb0
@molleer
Require only for kit members but, added tests and documentation
0a67b0b
@molleer
Filter away admin from getting group mail
c99f1c6
@Gurrit Gurrit marked this pull request as ready for review July 6, 2020 19:39
Gurrit
Gurrit approved these changes Jul 6, 2020
View reviewed changes
Copy link
Member

@Gurrit Gurrit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works as advertised

Portals
Portals approved these changes Jul 6, 2020
View reviewed changes
Copy link
Member

@Portals Portals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great f*cking work @molleer <3

@molleer molleer merged commit 8f3048f into master Jul 6, 2020
@molleer molleer deleted the gamma-integration branch July 6, 2020 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Portals Portals Portals approved these changes

@Gurrit Gurrit Gurrit approved these changes

@williamleven williamleven Awaiting requested review from williamleven

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@molleer @Portals @Gurrit