retire macos-12 from CI #1032
Merged
retire macos-12 from CI #1032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scholarsmate
force-pushed
the
remove_macos-12_from_CI
branch
from
9833b39 to
3634d76
Compare
scholarsmate
changed the title
scholarsmate
force-pushed
the
remove_macos-12_from_CI
branch
from
3634d76 to
a6522f1
Compare
scholarsmate
force-pushed
the
remove_macos-12_from_CI
branch
from
a6522f1 to
d80688d
Compare
|
@scholarsmate I added macos-13 in to replace macos-12 as its x86 based, this way we keep that support. However, I do believe |
shanedell
approved these changes
Dec 5, 2024
There was a problem hiding this comment.
+1 @scholarsmate just take a look make sure you like everything I changed and this should be good to merge
|
Thanks @shanedell, the changes look good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.