Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server shutdown RPC service #553

Closed
scholarsmate opened this issue Feb 28, 2023 · 0 comments · Fixed by #558
Closed

Server shutdown RPC service #553

scholarsmate opened this issue Feb 28, 2023 · 0 comments · Fixed by #558
Assignees
Milestone

Comments

@scholarsmate
Copy link
Member

There needs to be an RPC service that can shutdown the RPC server.

The rpc service can be defined as follows:

service Editor {
  ...
  rpc ServerControl(ServerControlRequest) returns (ServerControlResponse);
}

enum ServerControlKind {
  SERVER_CONTROL_UNDEFINED = 0;
  SERVER_CONTROL_GRACEFUL_SHUTDOWN = 1; // server will stop accepting new sessions and will exit when all sessions are destroyed
  SERVER_CONTROL_IMMEDIATE_SHUTDOWN = 2; // server will stop accepting new sessions and will exit immediately
}

message ServerControlRequest {
  ServerControlKind kind = 1; // server control kind
}

message ServerControlResponse {
  ServerControlKind kind = 1; // server control kind
  int32 response_code = 2; // response code, 0 for success, non-zero for failure
}
@scholarsmate scholarsmate added this to the v1.0.0 milestone Feb 28, 2023
shanedell added a commit that referenced this issue Mar 3, 2023
- Add ServerControl related RPC to proto.
- Wire in ServerControl to scala server code.
- Wire ServerControl into typescript client code with stopServerGraceful and stopServerImmediate.

Closes #553
shanedell added a commit that referenced this issue Mar 3, 2023
- Add ServerControl related RPC to proto.
- Wire in ServerControl to scala server code.
- Wire ServerControl into typescript client code with stopServerGraceful and stopServerImmediate.

Closes #553
shanedell added a commit that referenced this issue Mar 3, 2023
- Add ServerControl related RPC to proto.
- Wire in ServerControl to scala server code.
- Wire ServerControl into typescript client code with stopServerGraceful and stopServerImmediate.

Closes #553
shanedell added a commit that referenced this issue Mar 6, 2023
- Add ServerControl related RPC to proto.
- Wire in ServerControl to scala server code.
- Wire ServerControl into typescript client code with stopServerGraceful and stopServerImmediate.

Closes #553
shanedell added a commit that referenced this issue Mar 8, 2023
- Add ServerControl related RPC to proto.
- Wire in ServerControl to scala server code.
- Wire ServerControl into typescript client code with stopServerGraceful and stopServerImmediate.

Closes #553
shanedell added a commit that referenced this issue Mar 8, 2023
- Add ServerControl related RPC to proto.
- Wire in ServerControl to scala server code.
- Wire ServerControl into typescript client code with stopServerGraceful and stopServerImmediate.

Closes #553
shanedell added a commit that referenced this issue Mar 8, 2023
- Add ServerControl related RPC to proto.
- Wire in ServerControl to scala server code.
- Wire ServerControl into typescript client code with stopServerGraceful and stopServerImmediate.

Closes #553
shanedell added a commit that referenced this issue Mar 8, 2023
- Add ServerControl related RPC to proto.
- Wire in ServerControl to scala server code.
- Wire ServerControl into typescript client code with stopServerGraceful and stopServerImmediate.

Closes #553
shanedell added a commit that referenced this issue Mar 8, 2023
- Add ServerControl related RPC to proto.
- Wire in ServerControl to scala server code.
- Wire ServerControl into typescript client code with stopServerGraceful and stopServerImmediate.

Closes #553
shanedell added a commit that referenced this issue Mar 8, 2023
- Add ServerControl related RPC to proto.
- Wire in ServerControl to scala server code.
- Wire ServerControl into typescript client code with stopServerGraceful and stopServerImmediate.

Closes #553
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging a pull request may close this issue.

2 participants