Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix profiler page navigation #941

Merged
merged 1 commit into from
Nov 1, 2023
Merged

Conversation

jw3
Copy link
Member

@jw3 jw3 commented Nov 1, 2023

Explicitly declare the _unsaved_changes event on the profiler page to satisfy events.py introspection

Closes #940

@jw3 jw3 added this to the v1.2 milestone Nov 1, 2023
@jw3 jw3 mentioned this pull request Nov 1, 2023
@jw3
Copy link
Member Author

jw3 commented Nov 1, 2023

The fix addresses the check

        if hasattr(self, '__events__'):
            if name not in self.__events__:
                raise EventsException("Event '%s' is not declared" % name)

@jw3 jw3 merged commit 752456c into ctc-oss:master Nov 1, 2023
22 of 27 checks passed
@jw3 jw3 deleted the 921-fix_profiler_navigation branch November 1, 2023 12:19
@jw3
Copy link
Member Author

jw3 commented Nov 1, 2023

ref #921

@jw3 jw3 added the bug Something isn't working label Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transition away from profiler fails on unsaved changes check
1 participant