Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Daemon state preserved on session load #914

Merged

Conversation

tparchambault
Copy link
Contributor

@tparchambault tparchambault commented Sep 21, 2023

Modified code so that json session file operations are only applied to the current system object's state. No rollbacks or clearing of either the current system object maintained in the UI layer nor fapolicyd's state occur.

Closes #833

@tparchambault
Copy link
Contributor Author

I would like to verify that application restores post-crash are correct prior to merging.

@tparchambault tparchambault marked this pull request as draft September 21, 2023 20:43
@tparchambault tparchambault self-assigned this Sep 21, 2023
@tparchambault tparchambault marked this pull request as ready for review September 26, 2023 17:53
@tparchambault
Copy link
Contributor Author

Tested via rpm install over FC38. Simulated crash via # kill -p <pid> and observed expected behavior. Existing session file was detected on start-up, and the user was presented with a dialog providing them with the option to restore their prior session.

@tparchambault tparchambault requested a review from jw3 September 26, 2023 18:00
@jw3 jw3 changed the title daemon state modified on session load Daemon state preserved on session load Sep 26, 2023
@jw3 jw3 added this to the v1.2 milestone Sep 26, 2023
Copy link
Member

@jw3 jw3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jw3 jw3 merged commit 3679fb0 into ctc-oss:master Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Daemon state should not change when loading a user session json file
2 participants