-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Analysis time button bug fix #859
Conversation
@jw3 I think there might be an issue when parsing the |
Whats this say |
|
#868 describes what you are seeing. Quick fix is to update the syslog format. The playbook does that, I am guessing you didnt set this vm up from there.
|
Btw, this is a good find 👍 . That format change was made way back in development of the analysis view, I had forgot about it since then, but it definitely needs to be more robust. |
@jw3 This seems to be working after I cleared out the entries with the old format. Do you think its worth adding that grep as a check before enabling the time selection or is it better to open an issue with the parsing? |
Maybe the analyzer should warn the user if entries come back without a when value. You could detect that from the returned results and display a dialog that mentions the config items to check. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor suggested change. Otherwise the code looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good 👍
Fixes to allow the time selection button to properly filter syslog events.
Closes #832