Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rule Deployment Difference Dialog #849

Merged
merged 10 commits into from
Apr 28, 2023
Merged

Rule Deployment Difference Dialog #849

merged 10 commits into from
Apr 28, 2023

Conversation

egbicker
Copy link
Contributor

@egbicker egbicker commented Apr 14, 2023 •
edited by jw3
Loading

Adds an option to display a full difference in the rules changeset before deployment.

Closes #556

@egbicker egbicker requested a review from dorschs57 April 14, 2023 21:31
dorschs57
dorschs57 requested changes Apr 17, 2023
View reviewed changes
Copy link
Collaborator

@dorschs57 dorschs57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some test coverage as well.

fapolicy_analyzer/ui/confirm_deployment_dialog.py Outdated Show resolved Hide resolved
fapolicy_analyzer/ui/confirm_deployment_dialog.py Outdated Show resolved Hide resolved
fapolicy_analyzer/glade/confirm_deployment_dialog.glade Outdated Show resolved Hide resolved
fapolicy_analyzer/ui/rules_difference_dialog.py Outdated Show resolved Hide resolved
fapolicy_analyzer/ui/rules_difference_dialog.py Outdated Show resolved Hide resolved
fapolicy_analyzer/glade/rules_difference_dialog.glade Outdated Show resolved Hide resolved
@jw3
Copy link
Member

jw3 commented Apr 17, 2023

@egbicker is this ready?

@egbicker
Copy link
Contributor Author

@jw3 I'm just working on the tests, something about getting the current and previous system states in the test setup to actually exercise these changes is proving more difficult than expected. I reached out to @dorschs57 internally but I think he might be gone for the day.

@egbicker egbicker linked an issue Apr 20, 2023 that may be closed by this pull request
Enhance the rules deployment confirmation message #556
Closed
dorschs57
dorschs57 approved these changes Apr 25, 2023
View reviewed changes
Copy link
Collaborator

@dorschs57 dorschs57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jw3 jw3 merged commit 2834e29 into ctc-oss:master Apr 28, 2023
@jw3 jw3 mentioned this pull request Apr 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dorschs57 dorschs57 dorschs57 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhance the rules deployment confirmation message
3 participants
@egbicker @jw3 @dorschs57