You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The root deficiency here lies in the format of the session file. A new format that includes a type discriminator should be defined. At that time the deserialize function can be rewritten to match.
The text was updated successfully, but these errors were encountered:
We originally used a dict because of the supported translation to/fro json. Can we embed the strings into a dict so that we can maintain the json session file format? *-ish? Maybe that's a higher level dict now comprised of two sub-dicts? In any event, I'd like to maintain the json file format if possible.
Implements a new format for changesets to include a type discriminator
which assists with deserialization.
Previously the deserialization was deriving the value type by the type
of the serialized data, but this has issues when scaling to support
additional types.
Closes#917
Test
The trust record is serialized as a dict, the rule and config as strings.
The application is attempting to use nested exception handling to derive the flavor of string being deserialized from the session file.
https://github.com/ctc-oss/fapolicy-analyzer/blob/master/fapolicy_analyzer/ui/changeset_wrapper.py#L35-L59
The root deficiency here lies in the format of the session file. A new format that includes a type discriminator should be defined. At that time the deserialize function can be rewritten to match.
The text was updated successfully, but these errors were encountered: