Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Service active check #860

Closed
jw3 opened this issue Apr 28, 2023 · 0 comments · Fixed by #861
Closed

Service active check #860

jw3 opened this issue Apr 28, 2023 · 0 comments · Fixed by #861
Labels
bindings bug Something isn't working Rust
Milestone
v1.1

Comments

@jw3
Copy link
Member

jw3 commented Apr 28, 2023 •
edited
Loading

  1. Delete the fapolicyd.service file
  2. Do not do a systemctl daemon-reload
  3. Start fapolicy analyzer
Fapd Handle is_valid() or is_active() exception: DbusFailure(D-Bus error: Failed to get file context on /usr/lib/systemd/system/fapolicyd.service. (org.freedesktop.DBus.Error.AccessDenied))

Appears to be an unhandled state when querying dbus.

This was originally flattened out, looks like regression in 594bee0 where I started propagating the exception instead.

The original valid check is infallible contract should be restored.
@jw3 jw3 added this to the v1.1 milestone Apr 28, 2023
@jw3 jw3 added the bug Something isn't working label Apr 28, 2023
@jw3 jw3 mentioned this issue Apr 28, 2023
Merged
jw3 referenced this issue Apr 28, 2023
@jw3
Fix service active check (#852)
594bee0 
The active check now uses the unit's loaded status to determine validity.

This check may not be entirely accurate in general, but it is an
improvement and works in the cases we are concerned about.

Also: The cargo-vendor-filterer crate recently released a new version
that requires Rust 1.64. This PR pins our install in the Makefile to the
previous v0.5.8 for el8 compat.

Also: Commits the lock file which was missed back in #845

Closes #851
@jw3 jw3 mentioned this issue Apr 28, 2023
Merged
@jw3 jw3 closed this as completed in #861 Apr 28, 2023
jw3 added a commit that referenced this issue Apr 28, 2023
@jw3
Fix service valid check (#861)
3e88b86 
Fix a regression from 594bee0 by flattening the service valid check to
false on dbus error.

The original contract of the valid check was that it was infallible in
order to provide a simple way to check service status. The change was an
unintentional artifact left from debugging while improving the service
status checks.

Closes #860
@jw3 jw3 mentioned this issue Apr 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bindings bug Something isn't working Rust
Projects
None yet
Milestone
v1.1
Development

Successfully merging a pull request may close this issue.

Fix service valid check jw3/fapolicy-analyzer
1 participant
@jw3