Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tools entries from spec dependencies #723

Closed
jw3 opened this issue Dec 29, 2022 · 0 comments · Fixed by #718
Closed

Remove tools entries from spec dependencies #723

jw3 opened this issue Dec 29, 2022 · 0 comments · Fixed by #718

Comments

@jw3
Copy link
Member

jw3 commented Dec 29, 2022

The fapolicy-tools crate is built by request-only, not during the RPM build. There are dependencies in the spec file that are taken from the global lock file which includes these tool-only deps.

Quick and ephemeral way to resolve this is to exclude the tools from the workspace, generate new lock file, run lock2spec.

@jw3 jw3 added this to the v1.0 milestone Dec 29, 2022
@jw3 jw3 changed the title Do not build tools by default Remove tools entries from spec dependencies Dec 29, 2022
@jw3 jw3 mentioned this issue Dec 29, 2022
2 tasks
@jw3 jw3 closed this as completed in ecd1eef Dec 29, 2022
jw3 added a commit that referenced this issue Dec 30, 2022
Addresses findings from the first Fedora review.

Also includes some other distantly related, but supportive, changes.

Addresses several findings from first Fedora review (#715):
- Adding desktop file
- Adding man page
- Proper installation of translated help
- Cleaning up lints in the spec
- Reduces rpm deps by removing tool-only deps

Also
- Upgrades Clap
- Makes the top level Rust project a virtual project
- Makes crates/tools a standalone crate
- Upgrades some Actions
- Adds a checksum to wf to aid in debugging

Closes #616
Closes #722
Closes #723
# Conflicts:
#	Cargo.toml
#	crates/pyo3/src/check.rs
#	crates/tools/src/fapolicy_profiler.rs
#	fapolicy-analyzer.spec
#	help/__init__.py
#	scripts/srpm/fapolicy-analyzer.spec
jw3 added a commit that referenced this issue Dec 30, 2022
Addresses findings from the first Fedora review.

Also includes some other distantly related, but supportive, changes.

Addresses several findings from first Fedora review (#715):
- Adding desktop file
- Adding man page
- Proper installation of translated help
- Cleaning up lints in the spec
- Reduces rpm deps by removing tool-only deps

Also
- Upgrades Clap
- Makes the top level Rust project a virtual project
- Makes crates/tools a standalone crate
- Upgrades some Actions
- Adds a checksum to wf to aid in debugging

Closes #616
Closes #722
Closes #723
# Conflicts:
#	Cargo.toml
#	crates/pyo3/src/check.rs
#	crates/tools/src/fapolicy_profiler.rs
#	fapolicy-analyzer.spec
#	help/__init__.py
#	scripts/srpm/fapolicy-analyzer.spec
jw3 added a commit that referenced this issue Jan 2, 2023
Addresses findings from the first Fedora review.

Also includes some other distantly related, but supportive, changes.

Addresses several findings from first Fedora review (#715):
- Adding desktop file
- Adding man page
- Proper installation of translated help
- Cleaning up lints in the spec
- Reduces rpm deps by removing tool-only deps

Also
- Upgrades Clap
- Makes the top level Rust project a virtual project
- Makes crates/tools a standalone crate
- Upgrades some Actions
- Adds a checksum to wf to aid in debugging

Closes #616
Closes #722
Closes #723
# Conflicts:
#	Cargo.toml
#	crates/pyo3/src/check.rs
#	crates/tools/src/fapolicy_profiler.rs
#	fapolicy-analyzer.spec
#	help/__init__.py
#	scripts/srpm/fapolicy-analyzer.spec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant