Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

low-latency-short-buffer-playback__t2.html failed on 7 of 8 TV sets in London plugfest #153

Open
jpiesing opened this issue Mar 15, 2024 · 14 comments
Assignees
Labels
London 2024 Plugfest Issues from London plugfest in Feb/Mar 2024 Release V2 Deferred to Release V2

Comments

@jpiesing
Copy link

low-latency-short-buffer-playback__t2.html failed the "[OF] Every video frame S[k,s] shall be rendered and the video frames shall be rendered in increasing presentation time order." observation on 7 of 8 TV sets in the London plugfest.

@jpiesing jpiesing added Release V2 Deferred to Release V2 London 2024 Plugfest Issues from London plugfest in Feb/Mar 2024 labels Mar 15, 2024
@jpiesing
Copy link
Author

cta-wave/device-playback-task-force#126 applies here.

@yanj-github
Copy link
Contributor

Re; cta-wave/device-playback-task-force#128 and updated spec r2.05:

"low-latency-short-buffer-playback.html": {
"maximum_forward_buffer": 500,
"waiting_timeout": 500
}
@FritzHeiden is it easy to update the configuration to match the spec change?

  • Observation: The video element transitions into playing state before the waiting_duration, timeout elapses.
    Test runner terminates test when this observation is not met, is it possible to be observed by test runner, does test runner already reporting error for this observation please?
    If not, I am not sure how OF can make this observation from test runner status QR code? Maybe test runner can report error in status QR code?

@FritzHeiden
Copy link
Collaborator

@FritzHeiden is it easy to update the configuration to match the spec change?

Yes it is. Should I go ahead and push this to master?

  • Observation: The video element transitions into playing state before the waiting_duration, timeout elapses.
    Test runner terminates test when this observation is not met, is it possible to be observed by test runner, does test runner already reporting error for this observation please?
    If not, I am not sure how OF can make this observation from test runner status QR code? Maybe test runner can report error in status QR code?

I can add an error event for this

@yanj-github
Copy link
Contributor

@FritzHeiden is it easy to update the configuration to match the spec change?

Yes it is. Should I go ahead and push this to master?

It is up to you. If no regression concerns (it might be used HTML+JS of dpctf-tests) and easy to change please go ahead. If the change has a rick of breaking anything please raise it cta-wave/device-playback-task-force#128 it might be simpler to change the spec now. OF does not use this parameter so we are fine on OF end.

  • Observation: The video element transitions into playing state before the waiting_duration, timeout elapses.
    Test runner terminates test when this observation is not met, is it possible to be observed by test runner, does test runner already reporting error for this observation please?
    If not, I am not sure how OF can make this observation from test runner status QR code? Maybe test runner can report error in status QR code?

I can add an error event for this

Yes please if this can be done. So when OF detects the specific error event reports failure other wise the test will pass.

@jpiesing
Copy link
Author

2024-05-14: We need to decide if this can be closed now and, if not, what needs to be done before it can be closed.

@jpiesing
Copy link
Author

jpiesing commented May 14, 2024

2024-05-14: Fraunhofer and Resillion will coordinate.

@yanj-github
Copy link
Contributor

@FritzHeiden @louaybassbouss and @jpiesing re; #153 (comment):

  1. Can we update "waiting_timeout" to "waiting_duration" in test-config.json please?
  2. or update spec to replace "waiting_duration" with "waiting_timeout"?

Whichever is easier at this stage. All other tests uses "waiting_duration" so option 1 will make the parameter more consistent with others. OF does not read this parameter so no impact on OF end.

@yanj-github
Copy link
Contributor

Also cta-wave/device-observation-framework#82 I have added issue on OF.
We are waiting for error event to be added.

@FritzHeiden
Copy link
Collaborator

1. Can we update "waiting_timeout" to "waiting_duration" in test-config.json please?

Done with #180

@jpiesing
Copy link
Author

What does this mean for running the OF on recordings from the London plugfest? Will the release version of the OF stop supporting those recordings?

@FritzHeiden
Copy link
Collaborator

What does this mean for running the OF on recordings from the London plugfest? Will the release version of the OF stop supporting those recordings?

This parameter is only relevant for executing the test. As Yan already mentioned, the OF ignores this parameter, so this should have no impact on analyzing older recordings.

@yanj-github
Copy link
Contributor

yanj-github commented May 16, 2024

Thanks @FritzHeiden OF does not use this parameter, no OF changes required. and so no impact.

@jpiesing
Copy link
Author

  • Observation: The video element transitions into playing state before the waiting_duration, timeout elapses.
    Test runner terminates test when this observation is not met, is it possible to be observed by test runner, does test runner already reporting error for this observation please?
    If not, I am not sure how OF can make this observation from test runner status QR code? Maybe test runner can report error in status QR code?

I can add an error event for this

@FritzHeiden Was the error event added?

@FritzHeiden
Copy link
Collaborator

@FritzHeiden Was the error event added?

This was already implemented as an error event, however, it did not help to understand why the test failed. So I removed it as an error and added a dedicated field in the report with #182

(last entry):
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
London 2024 Plugfest Issues from London plugfest in Feb/Mar 2024 Release V2 Deferred to Release V2
Projects
None yet
Development

No branches or pull requests

3 participants