Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ask 20240126_v0.10.4_src6_dec2276_tuned production #447

Merged
merged 3 commits into from
Feb 7, 2024

Conversation

alvmas
Copy link
Contributor

@alvmas alvmas commented Feb 6, 2024

New Prod config

Self check-list:

  • I have checked the lstchain config, in particular for:
    • az_tel instead of sin_az_tel if data to be analyzed have been produced with lstchain <= v0.9.7
    • "increase_nsb" and "increase_psf" are provided in "image_modifier" (if used)
  • I have checked the environment in the lstmcpipe config and it is the one used to analyse DL>1 data
  • I have provided the command (in README), or script (in additionnal .py file) used to produce the lstmcpipe config

New Prod Config

Prod_ID

20240126_v0.10.4_src6_dec2276_tuned

Short description of the config

Config for the processing of MC at dec_2276 with NSB tuning to src6 and src-dependent configuration using a specific NSB tunning for the source.

Why this config is needed

Reprocess the data at declination 22.76 with version of lstchain v0.10.4 and with new tunning for new source: src6.

Copy link

codecov bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (163698a) 31.78% compared to head (9d5e49b) 31.78%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #447   +/-   ##
=======================================
  Coverage   31.78%   31.78%           
=======================================
  Files          46       46           
  Lines        2850     2850           
=======================================
  Hits          906      906           
  Misses       1944     1944           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vuillaut
Copy link
Member

vuillaut commented Feb 6, 2024

@alvmas there is a missing coma line 168 of lstchain config in the energy regression features, to fix

Copy link
Member

@vuillaut vuillaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vuillaut vuillaut merged commit b26864f into master Feb 7, 2024
9 checks passed
@vuillaut vuillaut deleted the v0.10.4_src6_dec2276_tuned branch February 7, 2024 09:09
@vuillaut
Copy link
Member

vuillaut commented Feb 7, 2024

Prod started 🚀 @alvmas
The cluster is quite busy at the moment with the school and many analyses running so it could take a few days. I will let you know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants