Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

20231024 v0.10.4 base dec min 2924 min 1802 6166 #434

Merged
merged 4 commits into from
Oct 24, 2023

Conversation

vuillaut
Copy link
Member

@vuillaut vuillaut commented Oct 24, 2023

New Prod config

Self check-list:

  • I have checked the lstchain config, in particular for:
    • az_tel instead of sin_az_tel if data to be analyzed have been produced with lstchain <= v0.9.7
    • "increase_nsb" and "increase_psf" are provided in "image_modifier" (if used)
  • I have checked the environment in the lstmcpipe config and it is the one used to analyse DL>1 data
  • I have provided the command (in README), or script (in additionnal .py file) used to produce the lstmcpipe config

Prod_ID

Short description of the config

Base prod for missing declination in 20230901_v0.10.4_base_prod

lstmcpipe_generate_config PathConfigAllSkyFull --prod_id 20231024_v0.10.4_base_dec_min_2924_min_1802_6166 --dec_list dec_min_2924 dec_min_1802 dec_6166

contact: Thomas Vuillaume

Why this config is needed

Missing declinations, needed for a complete sky study.

@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9b95219) 31.95% compared to head (30d6733) 31.89%.
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #434      +/-   ##
==========================================
- Coverage   31.95%   31.89%   -0.07%     
==========================================
  Files          46       46              
  Lines        2835     2841       +6     
==========================================
  Hits          906      906              
- Misses       1929     1935       +6     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vuillaut vuillaut merged commit 97ebd5d into master Oct 24, 2023
@vuillaut vuillaut deleted the 20231024_v0.10.4_base_dec_min_2924_min_1802_6166 branch October 24, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant