Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use private data to validate lstchain config if possible, solving EFFECTIVE_FOCAL_LENGTH issue #431

Merged
merged 2 commits into from
Sep 28, 2023

Conversation

vuillaut
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (3f4ae9b) 31.95% compared to head (1caabac) 31.89%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #431      +/-   ##
==========================================
- Coverage   31.95%   31.89%   -0.07%     
==========================================
  Files          46       46              
  Lines        2835     2841       +6     
==========================================
  Hits          906      906              
- Misses       1929     1935       +6     
Files Coverage Δ
...mcpipe/scripts/script_lstmcpipe_validate_config.py 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vuillaut vuillaut merged commit f50cf26 into master Sep 28, 2023
@vuillaut vuillaut deleted the fix_validate_config branch September 28, 2023 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant