-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Producing source dependent MC production for zenith 20 deg #188
Conversation
Codecov Report
@@ Coverage Diff @@
## master #188 +/- ##
=======================================
Coverage 15.77% 15.77%
=======================================
Files 35 35
Lines 2117 2117
=======================================
Hits 334 334
Misses 1783 1783 Continue to review full report at Codecov.
|
@SeiyaNozaki Can you just confirm if the parameters are correct as we discussed? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this request @chaimain !
You need to use input parameters for source-dependent analysis at the training step.
The other concerns are:
- For source-dep analysis, point gamma MC should be used for RF training. I'm not sure where it can be configured but should be used.
- when creating source-dep IRF, we need to use an option of
--source-dep
. Can this option used just by modifying the configuration file? - I guess dl2_to_sensitivity will not work with source-dep analysis
Done, thanks for checking.
I have removed diffuse-gamma MC from the workflow. Will that be ok, or do you want it to be only restricted in the RF training?
I will raise an issue here to add such support.
For this, I have commented it from the lstmcpipe stages to be run. |
There is no need to use diffuse gamma, so it would be fine to remove diffuse-gamma MC, but also need to modify codes to add an option to use point-gamma MC as RF training: |
We can probably close this one and the 40 deg one. Unless anyone has any objections. |
Starting source-dependent MC production, after which we can produce with some MC tuning in a separate PR