Store true

[vuillaut]

No description provided.

[codecov]

Codecov Report

Merging #150 (6d02ca1) into master (2cb8bc6) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #150      +/-   ##
==========================================
- Coverage   14.07%   14.04%   -0.03%     
==========================================
  Files          33       33              
  Lines        2068     2072       +4     
==========================================
  Hits          291      291              
- Misses       1777     1781       +4     

Impacted Files	Coverage Δ
lstmcpipe/hiperta/hiperta_r0_to_dl1lstchain.py	0.00% <ø> (ø)
lstmcpipe/scripts/script_batch_filelist_rta.py	0.00% <0.00%> (ø)
lstmcpipe/stages/mc_process_dl1.py	0.00% <0.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2cb8bc6...6d02ca1. Read the comment docs.

[garciagenrique]

Sorry the prod was launched, won't be merging, at least for the moment

[LukasNickel]

Why can we not merge when a production is running?

[garciagenrique]

Why can we not merge when a production is running?

Wanted to tag before the exact version that created the HiPeRTa MC prod.

[garciagenrique]

And also because the PR is missing the corresponding changes to the strings that call these entry poins.

[garciagenrique]

Change also the way these entry points are called in the rest of the code, not only how the arguments are passed.

[vuillaut]

Change also the way these entry points are called in the rest of the code, not only how the arguments are passed.

Done.
lstmcpipe/scripts/script_batch_filelist_rta.py is not called anywhere, right?

[LukasNickel]

Change also the way these entry points are called in the rest of the code, not only how the arguments are passed.

Done. lstmcpipe/scripts/script_batch_filelist_rta.py is not called anywhere, right?

It seems to be called here:

lstmcpipe/lstmcpipe/stages/mc_r0_to_dl1.py

Line 210 in dfaf65c

f"{source_environment} lstmcpipe_rta_core_r0_dl1 -c {config_file} "

[LukasNickel]

I see no way to set this, how do you want to use it?

[LukasNickel]

It should probably be the debug flag we already have in lstmcpipe_start.py?

[garciagenrique]

hhmm right... 🤔

[garciagenrique]

Indeed, there are functionalities that were implemented long time ago, but now I'm not sure they make much sense.... (before you could configured HiPeRTA from the config file...). Same for keep_files indeed.

[garciagenrique]

I would propose.
Nobody uses hiperta functionality but me.
Let's not add extra args to the config file that will never be used.
Either I implement some optional args when hiperta workflow is set (and open an issue otherwise I will forgot), either (what would be most probable) I change the default value of the vars on the script by hand and I re-install if ever I need to used these args 🙈 🙈 🙈 🙈 - not that I do this always 😂

[garciagenrique]

Ok, now I recall. Whenever I needed these functionalities, I was directly changing things on the old and deprecated batch_files_rta.sh.

[garciagenrique]

Would give a though how to do things correctly, leaving the PR open for the moment.

[vuillaut]

@garciagenrique ?