New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Irf maker and cut optimiser #2473

Merged

kosack merged 195 commits into main from irf-maker

Feb 3, 2025

Contributor

Tobychev commented Nov 24, 2023

As we are planning to produce IRFs on events that were not used to select the GH cut, it makes sense to split the procedure generating IRFs into two tools. Because this splitting results in a large restructuring of the the previous PR on generating IRFs (#2315) that was basically working properly, I open a new PR to preserve the discussion on the old attempt and let its more or less functional code serve as easy reference.

Tobychev marked this pull request as draft

November 24, 2023 09:45

maxnoe reviewed

View reviewed changes

ctapipe/irf/binning.py Outdated Show resolved Hide resolved

maxnoe reviewed

View reviewed changes

ctapipe/irf/irf_classes.py Outdated Show resolved Hide resolved

maxnoe reviewed

View reviewed changes

ctapipe/irf/irf_classes.py Outdated Show resolved Hide resolved

maxnoe reviewed

View reviewed changes

ctapipe/irf/irf_classes.py Outdated Show resolved Hide resolved

maxnoe reviewed

View reviewed changes

ctapipe/irf/irf_classes.py Outdated Show resolved Hide resolved

maxnoe reviewed

View reviewed changes

ctapipe/irf/binning.py Outdated Show resolved Hide resolved

maxnoe reviewed

View reviewed changes

ctapipe/irf/optimise.py Outdated Show resolved Hide resolved

maxnoe reviewed

View reviewed changes

ctapipe/irf/optimise.py Outdated Show resolved Hide resolved

maxnoe reviewed

View reviewed changes

ctapipe/irf/optimise.py Outdated Show resolved Hide resolved

maxnoe reviewed

View reviewed changes

ctapipe/irf/select.py Outdated Show resolved Hide resolved

maxnoe reviewed

View reviewed changes

ctapipe/irf/select.py Outdated Show resolved Hide resolved

maxnoe reviewed

View reviewed changes

ctapipe/irf/select.py Outdated Show resolved Hide resolved

maxnoe reviewed

View reviewed changes

ctapipe/irf/select.py Outdated Show resolved Hide resolved

maxnoe reviewed

View reviewed changes

ctapipe/tools/make_irf.py Outdated Show resolved Hide resolved

maxnoe reviewed

View reviewed changes

ctapipe/tools/make_irf.py Outdated Show resolved Hide resolved

maxnoe reviewed

View reviewed changes

ctapipe/tools/make_irf.py Outdated Show resolved Hide resolved

maxnoe reviewed

View reviewed changes

ctapipe/tools/make_irf.py Outdated Show resolved Hide resolved

maxnoe reviewed

View reviewed changes

ctapipe/tools/make_irf.py Outdated Show resolved Hide resolved

maxnoe reviewed

View reviewed changes

ctapipe/tools/make_irf.py Outdated Show resolved Hide resolved

maxnoe reviewed

View reviewed changes

ctapipe/tools/make_irf.py Outdated Show resolved Hide resolved

maxnoe reviewed

View reviewed changes

ctapipe/tools/make_irf.py Outdated Show resolved Hide resolved

maxnoe reviewed

View reviewed changes

ctapipe/tools/make_irf.py Outdated Show resolved Hide resolved

maxnoe reviewed

View reviewed changes

ctapipe/irf/irfs.py Outdated Show resolved Hide resolved

Tobychev commented

View reviewed changes

ctapipe/tools/make_irf.py Outdated Show resolved Hide resolved

LukasBeiske force-pushed the irf-maker branch from 643a841 to 7c2efc7 Compare

January 15, 2024 09:27

maxnoe reviewed

View reviewed changes

ctapipe/irf/binning.py Outdated Show resolved Hide resolved

maxnoe mentioned this pull request

Closed

LukasBeiske force-pushed the irf-maker branch from 479be95 to 111dca2 Compare

April 29, 2024 11:50

maxnoe reviewed

View reviewed changes

src/ctapipe/irf/optimize.py Outdated Show resolved Hide resolved

LukasBeiske added 18 commits

January 31, 2025 15:07


          point-like -> spatial-selection-applied

e0da126


          Fix __init__ signatures; use __call__ in small Components; improve at…

5bc7f3d

…tribute names


          Adress minor comments

d6d1506


          EventPreProcessor -> EventPreprocessor and add EventQualityQuery

b48461f


          theta_cuts -> spatial_selection_table

1a5dbe8


          Make multiple angular resolution quantiles configurable

dfa76e8


          Also calculate psf for point-like IRF

d304c60


          Fix psf test

f423375


          Make CutOptimizers use DefaultRecoEnergyBins

e7ea330


          Do not requiere background events for percentile cuts

2da2069


          Add default config files for both tools to ctapipe-quickstart

2b3430a


          Fix docs

5676a3c


          Add new tools to tools doc page

ce57838


          Address some comments, rest later

cf72c72


          Remove unnecessary abbreviations

39540b8


          Slight rework of CutOptimizer API

ffdbbfc


          Only apply gh cuts for psf

5ff65ca


          use_true_energy -> use_reco_energy

c307815

LukasBeiske force-pushed the irf-maker branch from 8fddecf to c307815 Compare

January 31, 2025 14:09

This comment has been minimized.

Sign in to view


          Fix binning for sensitivity

1ad6c54

ctao-dpps-sonarqube bot commented Jan 31, 2025

Analysis Details

9 Issues

0 Bugs
0 Vulnerabilities
9 Code Smells

Coverage and Duplications

96.20% Coverage (93.90% Estimated after merge)
0.00% Duplicated Code (0.70% Estimated after merge)

Project ID: cta-observatory_ctapipe_AY52EYhuvuGcMFidNyUs

View in SonarQube

maxnoe approved these changes

View reviewed changes

maxnoe requested review from kosack, morcuended and LukasBeiske

January 31, 2025 15:39

LukasBeiske approved these changes

View reviewed changes

kosack approved these changes

View reviewed changes

kosack merged commit 14cb49a into main

13 checks passed

kosack deleted the irf-maker branch

February 3, 2025 10:10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet