Change spaces used for indentation into tabs #415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merging early to minimize potential future merge conflicts |
|
And how many bytes were 'saved' by this commit? 🤣 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #28, supersedes #330
This brings consistency to the entire project, where much of the existing code already used tabs.
Tabs are a natural choice for indentation. It's semantic, one character per one indent. It's easy to adjust. It's easy to recognize indentation errors where indentation is significant (ie, Python). Especially for this last reason I feel this is one place where PEP8 has made a grave mistake.
Note that this PR is not to debate tabs vs spaces nor PEP8, as maintainer we are decidedly tabs. Comments reserved for reporting missed conversions, regressions, or conflicts.