Ameliorate forum-post-new reactivity #657
Conversation
…e new data binding pattern that is standard for glimmer
| @@ -1,5 +1,5 @@ | |||
| <p class='card-text'> | |||
| <MdEditor @content={{content}} @textareaId='newForumPost' /> | |||
| <MdEditor @content={{this.content}} @textareaId='newForumPost' /> | |||
There was a problem hiding this comment.
note that this no longer refers to the content argument, but rather to the content value that comes from the controller. In this situation, that content property on the controller comes in the form of a getter.
If we wanted to still refer to the content argument, we would need to write @content rather than this.content
In glimmer components, this refers to the component itself, the component 'controller' so to speak. This is similar to how in octane route templates, this refers to the controller of the route.
There was a problem hiding this comment.
I also find that this nicely demonstrates how glimmer components will clarify code in general
DrumsnChocolate
changed the title
|
wait, this is already being taken care of in #567 nevertheless, the extra work here is useful, (and I came to basically the same solution but better, I'd say that is a great sign) |
DrumsnChocolate
changed the base branch from
staging
to
fix/forum-post-text-reset
DrumsnChocolate
changed the title
|
Ameliowhat |
Haha exactly my thought when I read this PR |
ref #641
rewrote to glimmer component, because I understand them better, and it allows me to use the
this.argsnamespace (see https://guides.emberjs.com/release/upgrading/current-edition/glimmer-components/#toc_benefits-of-glimmer-components)note that args are immutable in glimmer components, which requires an extra function to be passed as an argument. Via this function
onChangeContentwe can pass the new value up to the containing controller, in this caseposts/index(If you're familiar with Vue.js then this pattern should look familiar.)
This would be fixed when #539 is finished, but I thought it wouldn't hurt to fix this since creating forum post is still broken right now