Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update ember-cli to v4 (major) #512

Merged
merged 3 commits into from
May 7, 2023
Merged

chore(deps): update ember-cli to v4 (major) #512

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
464039b
chore(deps): update ember-cli to v4
renovate[bot] May 7, 2023
0f9fd85
Update nvmrc and add instruction to renovate
wilco375 May 7, 2023
0de7383
Make ember-cli same version as docker image
wilco375 May 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/renovate.json5
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@
"prBodyNotes": "### Upgrade Instructions\n\
* Wait until both `danlynn/ember-cli` and `ember-cli` have the same update{{#unless isPatch}}\n\
* Then follow this guide: https://cli.emberjs.com/release/basic-use/upgrading/#upgradinganemberappitself\n\
* Then update `.nvmrc` with the version used in dalynn/ember-cli and validate everything works with this Node version\n\
* Finally, make sure any package that was added to `package.json` by this process is added to `ignoreDeps` in [`renovate.json5`](https://github.com/csvalpha/amber-ui/blob/staging/.github/renovate.json5){{/unless}}"
},
{
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
16.13.1
18.14.2
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM danlynn/ember-cli:3.28.5@sha256:e51e83121cefac0ba13c2a39f60623532c99386e418f18f4d03b9f554058a6ae AS base
FROM danlynn/ember-cli:4.11.0@sha256:ec33e1a99bb5bd0b610f33b7e5c7cc09946a94f8d5686746939c82932257e747 AS base

ARG DEPLOY_TARGET='production'
ARG BUILD_HASH='unknown'
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
"ember-auto-import": "^2.2.4",
"ember-bootstrap": "^5.1.1",
"ember-can": "^4.2.0",
"ember-cli": "~3.28.5",
"ember-cli": "~4.11.0",
"ember-cli-babel": "^7.26.10",
"ember-cli-content-security-policy": "^2.0.3",
"ember-cli-dependency-checker": "^3.2.0",
Expand Down
Loading