feat: actionlint #498
Merged
feat: actionlint #498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -44,7 +44,7 @@ jobs: | |||
| env: | |||
| INPUT_MERGE: ${{ github.event.inputs.merge }} | |||
| run: | | |||
| if [ $GITHUB_REF_NAME = 'master' ]; then | |||
| if [ "$GITHUB_REF_NAME" = 'master' ]; then | |||
| if [ "${INPUT_MERGE,,}" = 'y' ]; then | |||
| git fetch origin staging | |||
| if ! git diff origin/master origin/staging --exit-code; then | |||
There was a problem hiding this comment.
I know this isn't related to this commit, but I'm wondering whether this condition is not the wrong way around; doesn't a non-zero exit code mean that there's differences between branches? According to man git-diff:
--exit-code Make the program exit with codes similar to diff(1). That is, it exits with 1 if there were differences and 0 means no differences.
Wouldn't that then mean that a truthy exit code means differences, and passing the exit code through a negation results in true when no diff?
that is, shouldn't it be:
if git diff --exit-code ... has_diff=true else has_diff=false? rather than
if ! git diff --exit-code ... has_diff=true else has_diff=false
There was a problem hiding this comment.
An exit code of 1 means the program has failed, and this negates that to a success and thus makes it pass the condition.
DrumsnChocolate
approved these changes
Mar 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Runs some checks on our workflow files.
Other information
https://github.com/rhysd/actionlint