Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(DestroyController): correctly bind this to modelSaveUtil #495

Merged
merged 2 commits into from
Mar 16, 2022

Conversation

guidojw
Copy link
Member

@guidojw guidojw commented Mar 13, 2022

Summary

this argument is not correctly bound to the modelSaveUtil method calls, this PR fixes that.

Other information

https://sentry.io/organizations/csvalpha/issues/3095718738/?project=186017&referrer=slack

@guidojw guidojw requested a review from wilco375 March 13, 2022 16:23
@guidojw guidojw changed the title fix(EditController): correctly bind this to modelSaveUtil fix(DestroyController): correctly bind this to modelSaveUtil Mar 13, 2022
@guidojw guidojw enabled auto-merge (squash) March 13, 2022 16:25
@guidojw guidojw linked an issue Mar 16, 2022 that may be closed by this pull request
@guidojw guidojw requested a review from DrumsnChocolate March 16, 2022 13:03
@guidojw guidojw disabled auto-merge March 16, 2022 15:34
@guidojw guidojw changed the title fix(DestroyController): correctly bind this to modelSaveUtil fix(EditController): correctly bind this to modelSaveUtil Mar 16, 2022
@guidojw guidojw changed the title fix(EditController): correctly bind this to modelSaveUtil fix(DestroyController): correctly bind this to modelSaveUtil Mar 16, 2022
@guidojw guidojw merged commit c42e668 into staging Mar 16, 2022
@guidojw guidojw deleted the fix/model-save-util-this-binding branch March 16, 2022 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants