refactor: make advertisement-tool-test ts

csvalpha · Dec 31, 2022 · faeea33 · faeea33
1 parent 7d4f25e
commit faeea33
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/app/components/advertisement-tool.hbs b/app/components/advertisement-tool.hbs
@@ -3,7 +3,10 @@
     <div class='d-flex adv-row flex-column flex-wrap justify-content-center'>
       {{#each advertisements as |advertisement index|}}
         {{#if advertisement.links}}
-          <div class='advertisement-item advertisement-item--full col-auto'>
+          <div
+            class='advertisement-item advertisement-item--full col-auto'
+            data-test-advertisement-item
+          >
             {{#each advertisement.links as |link|}}
               <a
                 class='d-block text-primary'
@@ -22,6 +25,7 @@
             href={{advertisement.link}}
             title={{advertisement.title}}
             target='_blank'
+            data-test-advertisement-item
           >
             <img
               src={{advertisement.image}}

diff --git a/...ion/components/advertisement-tool-test.js → ...ion/components/advertisement-tool-test.ts b/...ion/components/advertisement-tool-test.js → ...ion/components/advertisement-tool-test.ts
@@ -9,11 +9,9 @@ module('Integration | Component | advertisement-tool', function (hooks) {
   test('should render all ads', async function (assert) {
     assert.expect(1);
 
-    await render(hbs`{{advertisement-tool}}`);
+    await render(hbs`<AdvertisementTool />`);
 
-    assert.equal(
-      this.element.querySelectorAll('.advertisement-item').length,
-      34 // Number of advertisements times two
-    );
+    // Number of advertisements times two
+    assert.dom('[data-test-advertisement-item]').exists({ count: 34 });
   });
 });