apply suggestions and comments

csvalpha · Oct 2, 2024 · e9b05e1 · e9b05e1
1 parent a938734
commit e9b05e1
Show file tree

Hide file tree

Showing 14 changed files with 19 additions and 19 deletions.
diff --git a/app/components/photo-albums/photo.hbs b/app/components/photo-albums/photo.hbs
@@ -1,5 +1,5 @@
 <div class='d-flex justify-content-center align-items-center'>
-  {{#if this.showComments}}
+  {{#if this.showTags}}
     <PhotoTags::PhotoTags @model={{@model}}>
       <img src={{@model.imageUrl}} class='photo-large' />
     </PhotoTags::PhotoTags>

diff --git a/app/components/photo-albums/photo.js b/app/components/photo-albums/photo.js
@@ -13,7 +13,7 @@ export default class Photo extends Component {
     return this.args.showInfo ?? true;
   }
 
-  get showComments() {
+  get showTags() {
     return this.showInfo && this.abilities.can('show photo-tags');
   }
 

diff --git a/app/components/photo-tags/photo-tags.hbs b/app/components/photo-tags/photo-tags.hbs
@@ -24,14 +24,14 @@
     </div>
   {{/each}}
 
-  {{#if newTagStyle }}
-    <div class="photo-tag photo-tag--new" style={{ newTagStyle }}>
+  {{#if this.newTagStyle }}
+    <div class="photo-tag photo-tag--new" style={{ this.newTagStyle }}>
       <PowerSelect
         @options={{this.users}}
-        @onChange={{action 'storeTag'}}
+        @onChange={{this.storeTag}}
         @searchEnabled={{true}}
         @searchField='fullName'
-        @registerAPI={{ action 'openUserSelect' }}
+        @registerAPI={{this.openUserSelect}}
         as |user|
       >
         {{user.fullName}}

diff --git a/app/templates/users/user/edit/index.hbs b/app/templates/users/user/edit/index.hbs
@@ -1,4 +1,4 @@
-<TabbedView @tabItems={{tabItems}}>
+<TabbedView @tabItems={{this.tabItems}}>
   <Forms::UserForm
     @model={{@model}}
     @onSubmit={{action 'submit'}}

diff --git a/app/templates/users/user/edit/permissions.hbs b/app/templates/users/user/edit/permissions.hbs
@@ -1,4 +1,4 @@
-<TabbedView @tabItems={{tabItems}}>
+<TabbedView @tabItems={{this.tabItems}}>
   <form class='form' {{action 'submit' on='submit'}}>
     <h5>Permissies</h5>
     <Permissions::PermissionsTable

diff --git a/app/templates/users/user/edit/privacy.hbs b/app/templates/users/user/edit/privacy.hbs
@@ -1,3 +1,3 @@
-<TabbedView @tabItems={{tabItems}}>
+<TabbedView @tabItems={{this.tabItems}}>
   <Users::PrivacySettings @model={{model}} @onSubmit={{action 'submit'}} @onCancel={{action 'cancel'}}/>
 </TabbedView>
diff --git a/app/templates/users/user/edit/security.hbs b/app/templates/users/user/edit/security.hbs
@@ -1,4 +1,4 @@
-<TabbedView @tabItems={{tabItems}}>
+<TabbedView @tabItems={{this.tabItems}}>
   <Users::PasswordSettings @model={{model}} />
   <br /><hr />
   <Users::OtpSettings @model={{model}} />

diff --git a/app/templates/users/user/groups.hbs b/app/templates/users/user/groups.hbs
@@ -2,7 +2,7 @@
   <PageActionsButtons @pageActions={{pageActions}} />
 </EmberWormhole>
 
-<TabbedView @tabItems={{tabItems}}>
+<TabbedView @tabItems={{this.tabItems}}>
   <div class='row tabs-with-filterbar-row'>
     <div class='col'>
       <ul class='nav nav-tabs d-flex'>

diff --git a/app/templates/users/user/index.hbs b/app/templates/users/user/index.hbs
@@ -2,7 +2,7 @@
   <PageActionsButtons @pageActions={{pageActions}} />
 </EmberWormhole>
 
-<TabbedView @tabItems={{tabItems}}>
+<TabbedView @tabItems={{this.tabItems}}>
   <div class='col'>
     <div class='card-body'>
       <p class='card-text'>

diff --git a/app/templates/users/user/mail.hbs b/app/templates/users/user/mail.hbs
@@ -2,7 +2,7 @@
   <PageActionsButtons @pageActions={{pageActions}} />
 </EmberWormhole>
 
-<TabbedView @tabItems={{tabItems}}>
+<TabbedView @tabItems={{this.tabItems}}>
   <h5>Mail aliassen</h5>
   <div class='table-responsive'>
     <table class='table'>

diff --git a/app/templates/users/user/mandates.hbs b/app/templates/users/user/mandates.hbs
@@ -2,7 +2,7 @@
   <PageActionsButtons @pageActions={{pageActions}} />
 </EmberWormhole>
 
-<TabbedView @tabItems={{tabItems}}>
+<TabbedView @tabItems={{this.tabItems}}>
   <h5>Incasso mandaten</h5>
 
   <table class='table'>

diff --git a/app/templates/users/user/permissions.hbs b/app/templates/users/user/permissions.hbs
@@ -2,7 +2,7 @@
   <PageActionsButtons @pageActions={{pageActions}} />
 </EmberWormhole>
 
-<TabbedView @tabItems={{tabItems}}>
+<TabbedView @tabItems={{this.tabItems}}>
   <h5>Persoonlijke rechten</h5>
   <div class='table-responsive'>
     <Permissions::PermissionsTable

diff --git a/app/templates/users/user/photos.hbs b/app/templates/users/user/photos.hbs
@@ -2,11 +2,11 @@
   <PageActionsButtons @pageActions={{pageActions}} />
 </EmberWormhole>
 
-<TabbedView @tabItems={{tabItems}}>
+<TabbedView @tabItems={{this.tabItems}}>
   <h5>Foto's</h5>
 
   <div class='row px-3'>
-    {{#each model.sortedPhotos as |photo|}}
+    {{#each @model.sortedPhotos as |photo|}}
       <div class='col-md-3 col-xs-6 photo-album-image-card'>
         <LinkTo
           @route='photo-albums.photo-album.photos.photo'
@@ -18,7 +18,7 @@
     {{else}}
       <div class='alert alert-warning'>
         <LinkTo @route='photo-albums.photo-album.edit' @model={{model.id}}>
-          Geen foto's gevonden waarin {{ model.fullName }} getagd is.
+          Geen foto's gevonden waarin {{ @model.fullName }} getagd is.
         </LinkTo>
       </div>
     {{/each}}

diff --git a/app/templates/users/user/settings.hbs b/app/templates/users/user/settings.hbs
@@ -2,7 +2,7 @@
   <PageActionsButtons @pageActions={{pageActions}} />
 </EmberWormhole>
 
-<TabbedView @tabItems={{tabItems}}>
+<TabbedView @tabItems={{this.tabItems}}>
   <p>
     Deze informatie is alleen voor jou, het bestuur en de ICT-commissie
     beschikbaar