refactor: change to Signature type parameter

csvalpha · Oct 15, 2023 · d03cbe4 · d03cbe4
1 parent 5c0cca7
commit d03cbe4
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 13 deletions.
diff --git a/app/components/model-form/file-input.ts b/app/components/model-form/file-input.ts
@@ -4,13 +4,15 @@ import type { UploadFile } from 'ember-file-upload';
 import { action } from '@ember/object';
 import { tracked } from '@glimmer/tracking';
 
-export interface FileInputSignature extends TextInputSignature {
-  validMimeTypes?: string[];
-  validExtensions?: string[];
-  loadedCallback: (
-    file: UploadFile,
-    data: Awaited<ReturnType<UploadFile['readAsDataURL']>>
-  ) => void;
+export interface FileInputSignature {
+  Args: TextInputSignature['Args'] & {
+    validMimeTypes?: string[];
+    validExtensions?: string[];
+    loadedCallback: (
+      file: UploadFile,
+      data: Awaited<ReturnType<UploadFile['readAsDataURL']>>
+    ) => void;
+  };
 }
 
 export default class FileInput extends TextInput<FileInputSignature> {

diff --git a/app/components/model-form/text-input.ts b/app/components/model-form/text-input.ts
@@ -2,12 +2,14 @@ import Component from '@glimmer/component';
 import type Model from '@ember-data/model';
 
 export interface TextInputSignature<T extends Model = Model> {
-  inputLayout?: string;
-  labelClass?: string;
-  inputWrapperClass?: string;
-  model: T;
-  property: keyof T;
-  label: string;
+  Args: {
+    inputLayout?: string;
+    labelClass?: string;
+    inputWrapperClass?: string;
+    model: T;
+    property: keyof T;
+    label: string;
+  };
 }
 
 export default class TextInput<