chore(deps): update ember-cli to v4 (major) (#512)

* chore(deps): update ember-cli to v4 * Update nvmrc and add instruction to renovate * Make ember-cli same version as docker image --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Wilco van Beijnum <[email protected]>
csvalpha · May 7, 2023 · 812af11 · 812af11
1 parent 81c1f6e
commit 812af11
Show file tree

Hide file tree

Showing 5 changed files with 1,245 additions and 189 deletions.
diff --git a/.github/renovate.json5 b/.github/renovate.json5
@@ -53,6 +53,7 @@
       "prBodyNotes": "### Upgrade Instructions\n\
 * Wait until both `danlynn/ember-cli` and `ember-cli` have the same update{{#unless isPatch}}\n\
 * Then follow this guide: https://cli.emberjs.com/release/basic-use/upgrading/#upgradinganemberappitself\n\
+* Then update `.nvmrc` with the version used in dalynn/ember-cli and validate everything works with this Node version\n\
 * Finally, make sure any package that was added to `package.json` by this process is added to `ignoreDeps` in [`renovate.json5`](https://github.com/csvalpha/amber-ui/blob/staging/.github/renovate.json5){{/unless}}"
     },
     {

diff --git a/.nvmrc b/.nvmrc
@@ -1 +1 @@
-16.13.1
+18.14.2
diff --git a/Dockerfile b/Dockerfile
@@ -1,4 +1,4 @@
-FROM danlynn/ember-cli:3.28.5@sha256:e51e83121cefac0ba13c2a39f60623532c99386e418f18f4d03b9f554058a6ae AS base
+FROM danlynn/ember-cli:4.11.0@sha256:ec33e1a99bb5bd0b610f33b7e5c7cc09946a94f8d5686746939c82932257e747 AS base
 
 ARG DEPLOY_TARGET='production'
 ARG BUILD_HASH='unknown'

diff --git a/package.json b/package.json
@@ -43,7 +43,7 @@
     "ember-auto-import": "^2.2.4",
     "ember-bootstrap": "^5.1.1",
     "ember-can": "^4.2.0",
-    "ember-cli": "~3.28.5",
+    "ember-cli": "~4.11.0",
     "ember-cli-babel": "^7.26.10",
     "ember-cli-content-security-policy": "^2.0.3",
     "ember-cli-dependency-checker": "^3.2.0",