fix: Stylelint fixes (#467)

csvalpha · Feb 9, 2022 · 56c5f3c · 56c5f3c
1 parent 7e85e1f
commit 56c5f3c
Show file tree

Hide file tree

Showing 5 changed files with 136 additions and 73 deletions.
diff --git a/.github/workflows/continuous-integration.yml b/.github/workflows/continuous-integration.yml
@@ -57,7 +57,8 @@ jobs:
         run: |
           EXIT_STATUS=0
           docker run app yarn ci:eslint || EXIT_STATUS=$?
-          node bin/convert-stylelint-output.js "$(docker run app yarn ci:stylelint)" || EXIT_STATUS=$?
+          STYLELINT_OUTPUT="$(docker run app yarn ci:stylelint)" || EXIT_STATUS=$?
+          node bin/convert-stylelint-output.js "$STYLELINT_OUTPUT"
           exit $EXIT_STATUS
 
   test:

diff --git a/app/styles/modules/card.scss b/app/styles/modules/card.scss
@@ -167,9 +167,6 @@ $card-border: 0 solid $gray-300;
 
 %gradient-overlay {
   background: linear-gradient(to bottom, $transparent 0%, $opaque-black-two-thirds 100%);
-  // stylelint-disable-next-line declaration-colon-space-after
-  filter:
-    progid:dximagetransform.microsoft.gradient(startColorstr='#00000000', endColorstr='#a6000000', GradientType=0);
 }
 
 .gradient-overlay {
@@ -183,7 +180,7 @@ $card-border: 0 solid $gray-300;
 }
 
 .card-subtitle {
-  margin-top: -(calc($card-spacer-y / 2));
+  margin-top: calc($card-spacer-y / -2);
   margin-bottom: 0;
 }
 

diff --git a/app/styles/modules/table.scss b/app/styles/modules/table.scss
@@ -37,28 +37,3 @@
   width: 100%;
   height: 100%;
 }
-
-// Monkeypatch responsive tables from v4.0
-/* stylelint-disable max-nesting-depth */
-.table-responsive {
-  @each $breakpoint in map-keys($grid-breakpoints) {
-    $next: breakpoint-next($breakpoint, $grid-breakpoints);
-    $infix: breakpoint-infix($next, $grid-breakpoints);
-
-    &#{$infix} {
-      @include media-breakpoint-down($breakpoint) {
-        display: block;
-        -webkit-overflow-scrolling: touch;
-        -ms-overflow-style: -ms-autohiding-scrollbar; // See https://github.com/twbs/bootstrap/pull/10057
-        overflow-x: auto;
-        width: 100%;
-
-        // Prevent double border on horizontal scroll due to use of `display: block;`
-        &.table-bordered {
-          border: 0;
-        }
-      }
-    }
-  }
-}
-/* stylelint-enable max-nesting-depth */
diff --git a/package.json b/package.json
@@ -95,7 +95,7 @@
     "qunit-dom": "^2.0",
     "remove-markdown": "^0.3",
     "sass": "^1.44.0",
-    "stylelint": "^14.1",
+    "stylelint": "^14.4.0",
     "stylelint-config-sass-guidelines": "^9.0",
     "stylelint-config-standard": "^25.0",
     "stylelint-order": "^5.0",