Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare token availability for codecov #441

Merged
merged 2 commits into from
Oct 23, 2024
Merged

Prepare token availability for codecov #441

merged 2 commits into from
Oct 23, 2024

Conversation

lodewiges
Copy link
Contributor

@lodewiges lodewiges commented Oct 23, 2024 •
edited by DrumsnChocolate
Loading

fix for #400

without this pullrequest the codecov PR will fail in continuous delivery due to not all keys being forwarded

lodewiges and others added 2 commits October 23, 2024 16:23
@DrumsnChocolate
Copy link
Contributor

Nice find, but I suspect we can add this change as part of #400 instead of merging this to staging separately. Do you agree, or is there a particular reason you opened a separate PR?

@lodewiges
Copy link
Contributor Author

lodewiges commented Oct 23, 2024 •
edited
Loading

no we cant, we need to have updated the master section of contious delivery before upload the other pr, this is because master(the old code) revers to staging(the new code). without the pr this will give a error and stop the delivery

@lodewiges
Copy link
Contributor Author

lodewiges commented Oct 23, 2024 •
edited
Loading

I also needed to do this for amber-ui in merge 11db032aa303b4934453665dedcd9a178ba91400. because before i did this it would crash. after the merge it was succesfull.

@lodewiges
Copy link
Contributor Author

i hope you understand it

@lodewiges lodewiges enabled auto-merge October 23, 2024 21:17
@DrumsnChocolate
Copy link
Contributor

DrumsnChocolate commented Oct 23, 2024 •
edited
Loading

I also needed to do this for amber-ui in merge 11db032aa303b4934453665dedcd9a178ba91400.

You can use the commit link next time, that makes life easier for me: csvalpha/amber-ui@11db032

i hope you understand it

I do not understand your explanation very well, but the fact that this worked for amber-ui is good enough

@DrumsnChocolate DrumsnChocolate changed the title Quick fix for codecov Prepare token availability for codecov Oct 23, 2024
@lodewiges lodewiges added this pull request to the merge queue Oct 23, 2024
Merged via the queue into staging with commit 5dfd9b9 Oct 23, 2024
3 checks passed
@lodewiges lodewiges deleted the bug/codecov-fix branch October 23, 2024 21:54
@lodewiges lodewiges mentioned this pull request Nov 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DrumsnChocolate DrumsnChocolate DrumsnChocolate approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lodewiges @DrumsnChocolate