Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: A group and user for each SOFIA role in the database seed #412

Merged
merged 4 commits into from
Nov 22, 2024

Conversation

Ellen-Wittingen
Copy link
Contributor

@Ellen-Wittingen Ellen-Wittingen commented Mar 18, 2024

Added a group and user for each SOFIA role. These groups are linked to the corresponding SOFIA role in SOFIA's database seed.

The SOFIA pull request #916 depends on this pull request

Copy link
Contributor

@lodewiges lodewiges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

simple but effective looks good, unable to test due to technical diffculties

@lodewiges
Copy link
Contributor

i tested it and it works

@lodewiges lodewiges added this pull request to the merge queue Nov 22, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 22, 2024
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.92%. Comparing base (5429b49) to head (8d53304).
Report is 2 commits behind head on staging.

Additional details and impacted files
@@           Coverage Diff            @@
##           staging     #412   +/-   ##
========================================
  Coverage    99.92%   99.92%           
========================================
  Files          203      203           
  Lines         2714     2714           
========================================
  Hits          2712     2712           
  Misses           2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@lodewiges lodewiges added this pull request to the merge queue Nov 22, 2024
Merged via the queue into staging with commit ae509a8 Nov 22, 2024
5 checks passed
@lodewiges lodewiges deleted the feat/sofia_secretary_role branch November 22, 2024 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants