Update brcast to ^3.0.1 #38
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: themeListener.subscribe returns subscriptionId intead of function. To unsubscribe you have to call themeListener.unsubscribe(subscriptionId) Fix tests
|
@oliviertassinari Can you check this? |
|
@darkowic I have been reducing the dependency on react-jss. By directly importing required modules, I would expect theming to no longer be required. |
kof
reviewed
Oct 14, 2017
| themeListener.unsubscribe(this.context, this.subscriptionId); | ||
| } | ||
| ``` | ||
| ``` |
kof
reviewed
Oct 14, 2017
| @@ -91,7 +91,7 @@ | |||
| "rimraf": "^2.6.1" | |||
| }, | |||
| "dependencies": { | |||
| "brcast": "^2.0.0", | |||
| "brcast": "^3.0.1", | |||
There was a problem hiding this comment.
this is an actual change corresponding the pr, or is there something else?
kof
reviewed
Oct 14, 2017
| @@ -18,13 +18,20 @@ export default function createThemeListener(CHANNEL = channel) { | |||
|
|
|||
| function subscribe(context, cb) { | |||
| if (context[CHANNEL]) { | |||
| return context[CHANNEL].subscribe(cb); | |||
| return context[CHANNEL].subscribe(cb); | |||
There was a problem hiding this comment.
formatting fixes should always go separate so that we know what has happened in a commit
kof
reviewed
Oct 14, 2017
| @@ -7,3 +7,4 @@ dist | |||
| shrinkwrap.* | |||
| .nyc_output | |||
| coverage | |||
| .idea | |||
|
@darkowic I know its a long due, can you please clean up the pr, separate the commits or even better send separate PRs? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: themeListener.subscribe returns subscriptionId intead of function. To unsubscribe you have to call themeListener.unsubscribe(subscriptionId)
Resolves #36