Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Update lerna #962

Merged
merged 4 commits into from
Dec 31, 2018
+1,642 −444
Merged

[core] Update lerna #962

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7e7fad5
Make all build scripts prepare and update lerna
Dec 31, 2018
c163fcf
Remove unnecessary lerna key inside lerna.json
Dec 31, 2018
1fc6d2e
Rename publish to publish-packages
Dec 31, 2018
9f66ec1
Update lerna.json
Dec 31, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions package.json
View file
Original file line number Diff line number Diff line change
@@ -5,8 +5,8 @@
"packages/*"
],
"scripts": {
"build": "lerna run build",
"prepublishOnly": "yarn check-snapshots && yarn build && yarn typecheck && yarn lint && yarn format:ci && yarn test",
"build": "lerna run prepare",
"prepublish": "yarn check-snapshots && yarn build && yarn typecheck && yarn lint && yarn format:ci && yarn test",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prepublish also runs on a regular install afaik

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean if you clone the repo and do npm i

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does yarn also do that? if not we are good

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it does run on yarn install. The reason why prepublish will not work is because it's in the root package file.

I renamed the script to publish-packages

"publish": "lerna publish",
"typecheck": "flow check --max-warnings=0",
"ts-check": "tsc",
@@ -69,7 +69,7 @@
"karma-mocha-reporter": "^2.2.1",
"karma-sourcemap-loader": "^0.3.7",
"karma-webpack": "^4.0.0-rc.5",
"lerna": "^2.11.0",
"lerna": "^3.8.0",
"lint-staged": "^3.2.2",
"mocha": "^3.2.0",
"pre-commit": "^1.1.3",
2 changes: 1 addition & 1 deletion packages/jss-plugin-cache/package.json
View file
Original file line number Diff line number Diff line change
@@ -34,7 +34,7 @@
"insane"
],
"scripts": {
"build": "node ../../scripts/build.js",
"prepare": "node ../../scripts/build.js",
"check-snapshot": "node ../../scripts/match-snapshot.js"
},
"devDependencies": {
2 changes: 1 addition & 1 deletion packages/jss-plugin-camel-case/package.json
View file
Original file line number Diff line number Diff line change
@@ -33,7 +33,7 @@
"camel case"
],
"scripts": {
"build": "node ../../scripts/build.js",
"prepare": "node ../../scripts/build.js",
"check-snapshot": "node ../../scripts/match-snapshot.js"
},
"devDependencies": {
2 changes: 1 addition & 1 deletion packages/jss-plugin-compose/package.json
View file
Original file line number Diff line number Diff line change
@@ -34,7 +34,7 @@
"composition"
],
"scripts": {
"build": "node ../../scripts/build.js",
"prepare": "node ../../scripts/build.js",
"check-snapshot": "node ../../scripts/match-snapshot.js"
},
"devDependencies": {
2 changes: 1 addition & 1 deletion packages/jss-plugin-default-unit/package.json
View file
Original file line number Diff line number Diff line change
@@ -35,7 +35,7 @@
"default-unit"
],
"scripts": {
"build": "node ../../scripts/build.js",
"prepare": "node ../../scripts/build.js",
"check-snapshot": "node ../../scripts/match-snapshot.js"
},
"devDependencies": {
2 changes: 1 addition & 1 deletion packages/jss-plugin-expand/package.json
View file
Original file line number Diff line number Diff line change
@@ -33,7 +33,7 @@
"expand"
],
"scripts": {
"build": "node ../../scripts/build.js",
"prepare": "node ../../scripts/build.js",
"check-snapshot": "node ../../scripts/match-snapshot.js"
},
"devDependencies": {
2 changes: 1 addition & 1 deletion packages/jss-plugin-extend/package.json
View file
Original file line number Diff line number Diff line change
@@ -33,7 +33,7 @@
"css in js"
],
"scripts": {
"build": "node ../../scripts/build.js",
"prepare": "node ../../scripts/build.js",
"check-snapshot": "node ../../scripts/match-snapshot.js"
},
"devDependencies": {
2 changes: 1 addition & 1 deletion packages/jss-plugin-global/package.json
View file
Original file line number Diff line number Diff line change
@@ -34,7 +34,7 @@
"unscoped"
],
"scripts": {
"build": "node ../../scripts/build.js",
"prepare": "node ../../scripts/build.js",
"check-snapshot": "node ../../scripts/match-snapshot.js"
},
"peerDependencies": {
2 changes: 1 addition & 1 deletion packages/jss-plugin-isolate/package.json
View file
Original file line number Diff line number Diff line change
@@ -34,7 +34,7 @@
"reset"
],
"scripts": {
"build": "node ../../scripts/build.js",
"prepare": "node ../../scripts/build.js",
"check-snapshot": "node ../../scripts/match-snapshot.js"
},
"devDependencies": {
2 changes: 1 addition & 1 deletion packages/jss-plugin-nested/package.json
View file
Original file line number Diff line number Diff line change
@@ -34,7 +34,7 @@
"nesting"
],
"scripts": {
"build": "node ../../scripts/build.js",
"prepare": "node ../../scripts/build.js",
"check-snapshot": "node ../../scripts/match-snapshot.js"
},
"devDependencies": {
2 changes: 1 addition & 1 deletion packages/jss-plugin-props-sort/package.json
View file
Original file line number Diff line number Diff line change
@@ -34,7 +34,7 @@
"props"
],
"scripts": {
"build": "node ../../scripts/build.js",
"prepare": "node ../../scripts/build.js",
"check-snapshot": "node ../../scripts/match-snapshot.js"
},
"devDependencies": {
2 changes: 1 addition & 1 deletion packages/jss-plugin-rule-value-function/package.json
View file
Original file line number Diff line number Diff line change
@@ -40,7 +40,7 @@
"animation"
],
"scripts": {
"build": "node ../../scripts/build.js",
"prepare": "node ../../scripts/build.js",
"check-snapshot": "node ../../scripts/match-snapshot.js"
},
"peerDependencies": {
2 changes: 1 addition & 1 deletion packages/jss-plugin-rule-value-observable/package.json
View file
Original file line number Diff line number Diff line change
@@ -39,7 +39,7 @@
"rxjs"
],
"scripts": {
"build": "node ../../scripts/build.js",
"prepare": "node ../../scripts/build.js",
"check-snapshot": "node ../../scripts/match-snapshot.js"
},
"peerDependencies": {
2 changes: 1 addition & 1 deletion packages/jss-plugin-template/package.json
View file
Original file line number Diff line number Diff line change
@@ -33,7 +33,7 @@
"template"
],
"scripts": {
"build": "node ../../scripts/build.js",
"prepare": "node ../../scripts/build.js",
"check-snapshot": "node ../../scripts/match-snapshot.js"
},
"devDependencies": {
2 changes: 1 addition & 1 deletion packages/jss-plugin-vendor-prefixer/package.json
View file
Original file line number Diff line number Diff line change
@@ -32,7 +32,7 @@
"prefixer"
],
"scripts": {
"build": "node ../../scripts/build.js",
"prepare": "node ../../scripts/build.js",
"check-snapshot": "node ../../scripts/match-snapshot.js"
},
"dependencies": {
2 changes: 1 addition & 1 deletion packages/jss-preset-default/package.json
View file
Original file line number Diff line number Diff line change
@@ -30,7 +30,7 @@
"default"
],
"scripts": {
"build": "node ../../scripts/build.js",
"prepare": "node ../../scripts/build.js",
"check-snapshot": "node ../../scripts/match-snapshot.js"
},
"devDependencies": {
2 changes: 1 addition & 1 deletion packages/jss-starter-kit/package.json
View file
Original file line number Diff line number Diff line change
@@ -36,7 +36,7 @@
"css-in-js"
],
"scripts": {
"build": "node ../../scripts/build.js",
"prepare": "node ../../scripts/build.js",
"check-snapshot": "node ../../scripts/match-snapshot.js"
},
"dependencies": {
2 changes: 1 addition & 1 deletion packages/jss/package.json
View file
Original file line number Diff line number Diff line change
@@ -36,7 +36,7 @@
"css-in-js"
],
"scripts": {
"build": "node ../../scripts/build.js",
"prepare": "node ../../scripts/build.js",
"check-snapshot": "node ../../scripts/match-snapshot.js"
},
"dependencies": {
2 changes: 1 addition & 1 deletion packages/react-jss/package.json
View file
Original file line number Diff line number Diff line change
@@ -34,7 +34,7 @@
"decorator"
],
"scripts": {
"build": "node ../../scripts/build.js",
"prepare": "node ../../scripts/build.js",
"check-snapshot": "node ../../scripts/match-snapshot.js"
},
"peerDependencies": {
Loading