Add escaping of keyframe names #1100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kof, please approve. Added a regression test for it. |
kof
reviewed
May 13, 2019
| it('should correctly escape the name', () => { | ||
| const localJss = create({ | ||
| createGenerateId() { | ||
| return (rule, sheet) => `${sheet.options.classNamePrefix}-${rule.key}-id` |
There was a problem hiding this comment.
can you move it to the createGenerateId we use everywhere in tests? Seems like this could be just used there without any issues, I mean without changing the class name in all assertions.
kof
approved these changes
May 13, 2019
|
@HenriBeck please add a changelog |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corresponding issue (if exists): #1098