New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added more tests #23

Open

msnider wants to merge 1 commit into cssinjs:master from msnider:feature/tests

Contributor

msnider commented Aug 7, 2018

Added a few more tests, particularly around special cases. For Issue #16


          Added more tests

bb85744

Member

kof commented Aug 7, 2018

I would write this function https://github.com/cssinjs/jss/blob/master/packages/jss/tests/utils.js#L59 and use setup the jss instance with it, so that test don't have generated ids, because in case they will change, tests will fail and we will have too many diffs in snapshots for no good reason.

Another point: I would use jest default settings and put integration tests into __tests__ and unit tests into {unit}.test.js

Otherwise looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet