Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate DefaultEntityResolver.resolveEntity(String) for removal #1

Closed
carlosame opened this issue Aug 12, 2021 · 0 comments
Closed

Deprecate DefaultEntityResolver.resolveEntity(String) for removal #1

carlosame opened this issue Aug 12, 2021 · 0 comments
Assignees
@carlosame
Milestone
3.5.2

Comments

@carlosame
Copy link
Member

Currently, the little-used DefaultEntityResolver.resolveEntity(String) method uses the DocumentTypeDeclaration class, which carries an external dependency to jclf-text.

Removing that method would make DefaultEntityResolver a bit lighter, and free from external dependencies. Somehow, the method already had a comment that it was "deprecated" but did not have any @Deprecated annotation.

The plan is:

  1. Deprecate for removal in 3.5.2.
  2. Remove in 4.0.0.

If you could be impacted by the removal of the method, please post a comment here.
@carlosame carlosame added this to the 3.5.2 milestone Aug 12, 2021
@carlosame carlosame self-assigned this Aug 12, 2021
carlosame added a commit that referenced this issue Aug 12, 2021
@carlosame
Deprecate DefaultEntityResolver.resolveEntity(String) for removal.
7d6443f 
See #1
carlosame added a commit that referenced this issue Dec 2, 2021
@carlosame
Remove DefaultEntityResolver.resolveEntity(String)
217dd86 
See #1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carlosame carlosame

Labels
None yet
Projects
None yet
Milestone
3.5.2
Development

No branches or pull requests
1 participant
@carlosame