Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"filter" IE property breaks csso v1.3.0 #86

Closed
doochik opened this issue Oct 8, 2012 · 4 comments
Closed

"filter" IE property breaks csso v1.3.0 #86

doochik opened this issue Oct 8, 2012 · 4 comments

Comments

@doochik
Copy link

doochik commented Oct 8, 2012

.ie-test
{
    filter: progid:DXImageTransform.Microsoft.gradient (startColorstr=#33CCCCCC, endColorstr=#33CCCCCC);
}

this code breaks csso

node_modules/csso/lib/gonzales.cssp.node.js:394
        throw message;
              ^
Error in line #3

Also, exception indicates invalid line:

.ie-test
{
    filter: progid:DXImageTransform.Microsoft.gradient (startColorstr=#33CCCCCC, endColorstr=#33CCCCCC);
}


.valid1
{
    left: 0
}

.valid2
{
    color: red;
}
node_modules/csso/lib/gonzales.cssp.node.js:394
        throw message;
              ^
Error in line #13
@afelix
Copy link
Contributor

afelix commented Oct 8, 2012

Fixed in 1.3.1.

@w8r
Copy link

w8r commented Feb 20, 2013

filter: progid: DXImageTransform.Microsoft.gradient(startColorstr='#b3000000', endColorstr='#e6000000', GradientType=0 );

causes

usr/local/lib/node_modules/csso/lib/gonzales.cssp.node.js:399
        throw new Error('Please check the validity of the CSS block starting f
              ^
Error: Please check the validity of the CSS block starting from the line #42
    at throwError (/usr/local/lib/node_modules/csso/lib/gonzales.cssp.node.js:399:15)
    at getBlock (/usr/local/lib/node_modules/csso/lib/gonzales.cssp.node.js:755:18)
    at getRuleset (/usr/local/lib/node_modules/csso/lib/gonzales.cssp.node.js:1739:22)
    at getStylesheet (/usr/local/lib/node_modules/csso/lib/gonzales.cssp.node.js:1936:56)
    at Object.CSSPRules.stylesheet (/usr/local/lib/node_modules/csso/lib/gonzales.cssp.node.js:365:69)
    at _getAST (/usr/local/lib/node_modules/csso/lib/gonzales.cssp.node.js:409:38)
    at /usr/local/lib/node_modules/csso/lib/gonzales.cssp.node.js:2287:16
    at Object.srcToCSSP (/usr/local/lib/node_modules/csso/lib/gonzales.cssp.node.js:2292:16)
    at exports.parse (/usr/local/lib/node_modules/csso/lib/cssoapi.js:7:21)
    at Object.exports.justDoIt (/usr/local/lib/node_modules/csso/lib/cssoapi.js:21:41)

@afelix
Copy link
Contributor

afelix commented Feb 20, 2013

2w8r: fast local fix — remove space after progid:, everything will be ok. :)
I'll check the validity of this space in MS manuals, thank you.

@w8r
Copy link

w8r commented Feb 20, 2013

@afelix Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants