Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable risc0-zkvm/client feature by default #158

Merged
merged 8 commits into from
Jul 30, 2024

Conversation

koxu1996
Copy link
Contributor

Fixes #157.

@koxu1996 koxu1996 self-assigned this Jul 23, 2024
@Avi-D-coder
Copy link
Contributor

I don't want to enable prove by default because it makes rust-analyzer spin up an endless c++ complication and breaks the lsp. I am not sure why the you are hitting #157. I can build without prove.

Are you in the devshell nix develop .#risczero?

@koxu1996
Copy link
Contributor Author

@Avi-D-coder I removed it from default features - 3bd10ad.

I tried building in the Nix shell - same result:

$ nix develop .#risczero
$ cd ./kairos-prover
$ cargo build -p kairos-prover-risc0-server
# compilation fails as described in #157

If there is no prove enabled then all Risc0 proving items are simply configured out.

@marijanp
Copy link
Contributor

@koxu1996 I can't reproduce the error

@koxu1996
Copy link
Contributor Author

@marijanp Are you compiling it without metal/cuda feature enabled?

@Avi-D-coder
Copy link
Contributor

Avi-D-coder commented Jul 26, 2024

Could we rename the feature something like build cpu prover.

Proving via cpu is normally provided by r0vm installed by cargo-risc0 or nix, hence I'd like to make it clear this builds that prover again.

@koxu1996
Copy link
Contributor Author

I'd like to make it clear this builds that prover again.

I didn't want to build prover again, but rather make ExternalProver available in the code. Therefore client feature is more suitable here:

image

It should be enabled by default, as it's a default fallback:

image

@Avi-D-coder Please check updated PR.

@koxu1996 koxu1996 changed the title Enable risc0-zkvm/prove feature by default Enable risc0-zkvm/client feature by default Jul 30, 2024
@koxu1996 koxu1996 merged commit 0e8f818 into main Jul 30, 2024
4 checks passed
@koxu1996 koxu1996 deleted the feature/allow-unaccelerated-proving branch July 30, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to build prover without CUDA/Metal acceleration
3 participants