-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable risc0-zkvm/client
feature by default
#158
Conversation
I don't want to enable Are you in the devshell |
It compiles really long and LSP is unresponsive at that time.
@Avi-D-coder I removed it from default features - 3bd10ad. I tried building in the Nix shell - same result: $ nix develop .#risczero
$ cd ./kairos-prover
$ cargo build -p kairos-prover-risc0-server
# compilation fails as described in #157 If there is no |
@koxu1996 I can't reproduce the error |
@marijanp Are you compiling it without metal/cuda feature enabled? |
Could we rename the feature something like build cpu prover. Proving via cpu is normally provided by r0vm installed by cargo-risc0 or nix, hence I'd like to make it clear this builds that prover again. |
I didn't want to build prover again, but rather make It should be enabled by default, as it's a default fallback: @Avi-D-coder Please check updated PR. |
risc0-zkvm/prove
feature by defaultrisc0-zkvm/client
feature by default
Fixes #157.