Consolidate depth coordinate methods #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mx-moth
force-pushed
the
task/140-consolidate-depth-coordinates
branch
from
08d5232 to
fec56a9
Compare
`Convention.depth_coordinate` and `Convention.depth_coordinates` are better suited to the job when used in conjunction with `utils.data_array_to_name` and `utils.name_to_data_array`.
Partial fix for #138
mx-moth
force-pushed
the
task/140-consolidate-depth-coordinates
branch
from
fec56a9 to
80e0128
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #140, there are far too many methods that deal with depth coordinates. Since #142 it is possible to use either a variable or its name interchangeably in most methods, making one of
Convention.depth_coordinateorConvention.get_depth_name()et al superfluous. This PR dropsConvention.get_depth_name()and similar methods in preference of using the coordinate variables directly.Closes #138, #140