Skip to content

Commit

Permalink
replication: make volume_id as optional
Browse files Browse the repository at this point in the history 
as we have ReplicationSource which can be
either volume or group id, mark the volume_id
as optional in the main struct and set it
in both ReplicationSource and volume_id for
backward compatibility for next release for
volume operation and set it to empty for
volume group replication.

Signed-off-by: Madhu Rajanna <[email protected]>
  • Loading branch information
@Madhu-1
Madhu-1 committed Jun 18, 2024
1 parent 2f3760d commit 32bad99
Show file tree
Hide file tree
Showing 3 changed files with 18 additions and 18 deletions.
12 changes: 6 additions & 6 deletions lib/go/replication/replication.pb.go
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 6 additions & 6 deletions replication/README.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ service Controller {
message EnableVolumeReplicationRequest {
// The identifier for this volume, generated by the plugin during
// CreateVolume CSI RPC call.
// This field is REQUIRED.
// This field is OPTIONAL.
// This field MUST contain enough information to uniquely identify
// this specific volume vs all other volumes supported by this plugin.
// This field SHALL be used by the CO in subsequent calls to refer to
Expand Down Expand Up @@ -146,7 +146,7 @@ message EnableVolumeReplicationResponse {
message DisableVolumeReplicationRequest {
// The identifier for this volume, generated by the plugin during
// CreateVolume CSI RPC call.
// This field is REQUIRED.
// This field is OPTIONAL.
// This field MUST contain enough information to uniquely identify
// this specific volume vs all other volumes supported by this plugin.
// This field SHALL be used by the CO in subsequent calls to refer to
Expand Down Expand Up @@ -193,7 +193,7 @@ message DisableVolumeReplicationResponse {
message PromoteVolumeRequest {
// The identifier for this volume, generated by the plugin during
// CreateVolume CSI RPC call.
// This field is REQUIRED.
// This field is OPTIONAL.
// This field MUST contain enough information to uniquely identify
// this specific volume vs all other volumes supported by this plugin.
// This field SHALL be used by the CO in subsequent calls to refer to
Expand Down Expand Up @@ -245,7 +245,7 @@ message PromoteVolumeResponse{
message DemoteVolumeRequest {
// The identifier for this volume, generated by the plugin during
// CreateVolume CSI RPC call.
// This field is REQUIRED.
// This field is OPTIONAL.
// This field MUST contain enough information to uniquely identify
// this specific volume vs all other volumes supported by this plugin.
// This field SHALL be used by the CO in subsequent calls to refer to
Expand Down Expand Up @@ -296,7 +296,7 @@ message DemoteVolumeResponse{
message ResyncVolumeRequest {
// The identifier for this volume, generated by the plugin during
// CreateVolume CSI RPC call.
// This field is REQUIRED.
// This field is OPTIONAL.
// This field MUST contain enough information to uniquely identify
// this specific volume vs all other volumes supported by this plugin.
// This field SHALL be used by the CO in subsequent calls to refer to
Expand Down Expand Up @@ -352,7 +352,7 @@ message ResyncVolumeResponse{
message GetVolumeReplicationInfoRequest {
// The identifier for this volume, generated by the plugin during
// CreateVolume CSI RPC call.
// This field is REQUIRED.
// This field is OPTIONAL.
// This field MUST contain enough information to uniquely identify
// this specific volume vs all other volumes supported by this plugin.
// This field SHALL be used by the CO in subsequent calls to refer to
Expand Down
12 changes: 6 additions & 6 deletions replication/replication.proto
View file
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ service Controller {
message EnableVolumeReplicationRequest {
// The identifier for this volume, generated by the plugin during
// CreateVolume CSI RPC call.
// This field is REQUIRED.
// This field is OPTIONAL.
// This field MUST contain enough information to uniquely identify
// this specific volume vs all other volumes supported by this plugin.
// This field SHALL be used by the CO in subsequent calls to refer to
Expand Down Expand Up @@ -76,7 +76,7 @@ message EnableVolumeReplicationResponse {
message DisableVolumeReplicationRequest {
// The identifier for this volume, generated by the plugin during
// CreateVolume CSI RPC call.
// This field is REQUIRED.
// This field is OPTIONAL.
// This field MUST contain enough information to uniquely identify
// this specific volume vs all other volumes supported by this plugin.
// This field SHALL be used by the CO in subsequent calls to refer to
Expand Down Expand Up @@ -108,7 +108,7 @@ message DisableVolumeReplicationResponse {
message PromoteVolumeRequest {
// The identifier for this volume, generated by the plugin during
// CreateVolume CSI RPC call.
// This field is REQUIRED.
// This field is OPTIONAL.
// This field MUST contain enough information to uniquely identify
// this specific volume vs all other volumes supported by this plugin.
// This field SHALL be used by the CO in subsequent calls to refer to
Expand Down Expand Up @@ -143,7 +143,7 @@ message PromoteVolumeResponse{
message DemoteVolumeRequest {
// The identifier for this volume, generated by the plugin during
// CreateVolume CSI RPC call.
// This field is REQUIRED.
// This field is OPTIONAL.
// This field MUST contain enough information to uniquely identify
// this specific volume vs all other volumes supported by this plugin.
// This field SHALL be used by the CO in subsequent calls to refer to
Expand Down Expand Up @@ -177,7 +177,7 @@ message DemoteVolumeResponse{
message ResyncVolumeRequest {
// The identifier for this volume, generated by the plugin during
// CreateVolume CSI RPC call.
// This field is REQUIRED.
// This field is OPTIONAL.
// This field MUST contain enough information to uniquely identify
// this specific volume vs all other volumes supported by this plugin.
// This field SHALL be used by the CO in subsequent calls to refer to
Expand Down Expand Up @@ -216,7 +216,7 @@ message ResyncVolumeResponse{
message GetVolumeReplicationInfoRequest {
// The identifier for this volume, generated by the plugin during
// CreateVolume CSI RPC call.
// This field is REQUIRED.
// This field is OPTIONAL.
// This field MUST contain enough information to uniquely identify
// this specific volume vs all other volumes supported by this plugin.
// This field SHALL be used by the CO in subsequent calls to refer to
Expand Down

0 comments on commit 32bad99

Please sign in to comment.