ci: limit the platforms that are build #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rakshith-R
requested changes
Jan 19, 2022
Madhu-1
reviewed
Jan 19, 2022
| @@ -9,8 +9,8 @@ on: | |||
| jobs: | |||
| build_bundle: | |||
| name: build_bundle | |||
| if: github.repository == 'csi-addons/kubernetes-csi-addons' | |||
There was a problem hiding this comment.
if we remove this won't these builds run on the fork repos?
There was a problem hiding this comment.
The other build_* tests do not have this line. Without any configuration, forks get a single-platform build test.
nixpanic
force-pushed
the
workflows/limit-architectures
branch
from
16fdffe to
29f243a
Compare
Signed-off-by: Niels de Vos <[email protected]>
Document the GitHub Environment variable `BUILD_PLATFORMS` that is now used in the jobs that test building container-images. Signed-off-by: Niels de Vos <[email protected]>
nixpanic
force-pushed
the
workflows/limit-architectures
branch
from
29f243a to
06be13e
Compare
|
closing, just to re-open again and restart GitHub Workflows |
|
Interesting 🙄 When creating a branch for PR #90 in this repository, the CI jobs have restarted and are using the |
Closed
|
@Madhu-1 this is now working as expected, please review again. Thanks! |
Madhu-1
approved these changes
Jan 19, 2022
| Settings of the repository. 'Normal' environment variables seem not possible. | ||
|
|
||
| An example of the GitHub Secret that will build the container-images on AMD64, | ||
| and both 32-bit and 64-bit Arm platforms: |
There was a problem hiding this comment.
https://www.arm.com/ uses Arm (I think that the new capitalization was introduced with some rebranding a while ago)
Rakshith-R
approved these changes
Jan 19, 2022
nixpanic
pushed a commit
to nixpanic/kubernetes-csi-addons
that referenced
this pull request
Oct 12, 2023
Sync the upstream changes from `csi-addons/kubernetes-csi-addons:main` into the `main` branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Document the GitHub Environment variable
BUILD_PLATFORMSthat is nowused in the jobs that test building container-images.