Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: make the CSV package-name configurable #86

Merged
merged 1 commit into from
Jan 18, 2022

Conversation

nixpanic
Copy link
Collaborator

By setting PACKAGE_NAME as an variable for the make generate bundle
command, the default "csi-addons" name can be adjusted. This is useful
to prevent conflicts while installing the component, specially when
products want to include their tested version of the CSI-Addons bundle.

Copy link

@b-ranto b-ranto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

By setting PACKAGE_NAME as an variable for the `make generate bundle`
command, the default "csi-addons" name can be adjusted. This is useful
to prevent conflicts while installing the component, specially when
products want to include their tested version of the CSI-Addons bundle.

Signed-off-by: Niels de Vos <[email protected]>
@mergify mergify bot merged commit 44e3984 into csi-addons:main Jan 18, 2022
nixpanic pushed a commit to nixpanic/kubernetes-csi-addons that referenced this pull request Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants