bundle: drop fixed :latest version from controller image-name
#72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The InstallMode `OwnNamespace` is required for deploying with
odf-operator. If this is not set, deploying fails with the following
error:
OwnNamespace InstallModeType not supported, cannot configure to watch own namespace
Tested-with: red-hat-storage/odf-operator#165
Signed-off-by: Niels de Vos <[email protected]>
The controller image-name should use the `TAG` just as other images.
When this is not done, the bundle includes the following reference to
the image, and fails to deploy:
quay.io/csiaddons/k8s-controller:latest:latest`
By using `TAG` as the other container images do, the bundle will refer
to the image with `:latest`, or the `TAG` that was used for creating a
release.
Signed-off-by: Niels de Vos <[email protected]>
Rakshith-R
approved these changes
Jan 14, 2022
yati1998
approved these changes
Jan 14, 2022
nixpanic
pushed a commit
to nixpanic/kubernetes-csi-addons
that referenced
this pull request
Mar 28, 2023
sync downstream main with upstream main branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The controller image-name should use the
TAGjust as other images.When this is not done, the bundle includes the following reference to
the image, and fails to deploy:
By using
TAGas the other container images do, the bundle will referto the image with
:latest, or theTAGthat was used for creating arelease.
The InstallMode
OwnNamespaceis required for deploying withodf-operator. If this is not set, deploying fails with the following
error:
Tested-with: red-hat-storage/odf-operator#165