Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rebase: use go.mod for go version #684

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Conversation

Madhu-1
Copy link
Member

@Madhu-1 Madhu-1 commented Sep 24, 2024

instead of defining own go version in test files we can use go.mod to setup the required version.

@black-dragon74
Copy link
Member

Additional ref: https://github.com/actions/setup-go?tab=readme-ov-file#getting-go-version-from-the-gomod-file

instead of defining own go version
in test files we can use go.mod to setup
the required version.

Signed-off-by: Madhu Rajanna <[email protected]>
Copy link
Collaborator

@nixpanic nixpanic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, much simpler!

@mergify mergify bot merged commit bd951fb into csi-addons:main Sep 24, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants