Include capabilities in CSIAddonsNode status

[black-dragon74]

This patch adds support to display advertised
capabilities in the status field of CSIAddonsNode

The capabilities are displayed in the format capability.Type like:

Status:
  Capabilities:
    service.NODE_SERVICE
    reclaim_space.ONLINE
    encryption_key_rotation.ENCRYPTIONKEYROTATION
  Message:  Successfully established connection with sidecar
  State:    Connected

Closes: #376

[Madhu-1]

add unit test for this one?

[black-dragon74]

Done.

[nixpanic]

can you add a little note/example of how a cap.String() looks like, and what the desired output for it is?

[black-dragon74]

Done

[nixpanic]

you already created a right sized slice, no need to re-create a new capabilities slice in every loop. You can be a little more efficient like this:

for i, cap := range caps {
    ...
    capabilities[i] = capStr
}

[black-dragon74]

Added a fixed slice later as an optimization and forgot to update the rest of the code to actually use that optimization. Classic.

Thank you! Fixed :)

[nixpanic]

@Mergifyio requeue

[mergify]

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

[nixpanic]

@Mergifyio rebase

[mergify]

rebase

✅ Branch has been successfully rebased