Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replication: add missing VRC name for VGR #597

Merged
merged 1 commit into from
Jun 20, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,11 @@ type VolumeGroupReplicationSpec struct {
// +kubebuilder:validation:XValidation:rule="self == oldSelf",message="volumeGroupReplicationClassName is immutable"
VolumeGroupReplicationClassName string `json:"volumeGroupReplicationClassName"`

// volumeReplicationClassName is the volumeReplicationClass name for VolumeReplication object
// +kubebuilder:validation:Required
// +kubebuilder:validation:XValidation:rule="self == oldSelf",message="volumReplicationClassName is immutable"
VolumeReplicationClassName string `json:"volumeReplicationClassName"`

// Name of the VolumeReplication object created for this volumeGroupReplication
// +kubebuilder:validation:Optional
// +kubebuilder:validation:XValidation:rule="self == oldSelf",message="volumeReplicationName is immutable"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,13 @@ spec:
x-kubernetes-validations:
- message: volumeGroupReplicationContentName is immutable
rule: self == oldSelf
volumeReplicationClassName:
description: volumeReplicationClassName is the volumeReplicationClass
name for VolumeReplication object
type: string
x-kubernetes-validations:
- message: volumReplicationClassName is immutable
rule: self == oldSelf
volumeReplicationName:
description: Name of the VolumeReplication object created for this
volumeGroupReplication
Expand All @@ -142,6 +149,7 @@ spec:
- replicationState
- source
- volumeGroupReplicationClassName
- volumeReplicationClassName
type: object
status:
description: VolumeGroupReplicationStatus defines the observed state of
Expand Down
8 changes: 8 additions & 0 deletions deploy/controller/crds.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -1153,6 +1153,13 @@ spec:
x-kubernetes-validations:
- message: volumeGroupReplicationContentName is immutable
rule: self == oldSelf
volumeReplicationClassName:
description: volumeReplicationClassName is the volumeReplicationClass
name for VolumeReplication object
type: string
x-kubernetes-validations:
- message: volumReplicationClassName is immutable
rule: self == oldSelf
volumeReplicationName:
description: Name of the VolumeReplication object created for this
volumeGroupReplication
Expand All @@ -1165,6 +1172,7 @@ spec:
- replicationState
- source
- volumeGroupReplicationClassName
- volumeReplicationClassName
type: object
status:
description: VolumeGroupReplicationStatus defines the observed state of
Expand Down
Loading