Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update k8s and controller runtime pkgs #379

Merged
merged 1 commit into from
Jun 26, 2023

Conversation

subhamkrai
Copy link
Contributor

build: update k8s and controller runtime pkgs

this commit update the kubernetes pkgs to latest 0.27.2
and controller runtime version to 1.15.0.

vendor: these are auto generated changes

Signed-off-by: subhamkrai [email protected]

@subhamkrai
Copy link
Contributor Author

depends on operator-framework/operator-sdk#6465

@Rakshith-R
Copy link
Member

@subhamkrai can you try to rebase on top of main branch now ?
Operator sdk should not be an issue now.

@subhamkrai subhamkrai force-pushed the update-k8s-version branch 2 times, most recently from 214b61b to aa93244 Compare June 26, 2023 08:14
@subhamkrai
Copy link
Contributor Author

@subhamkrai can you try to rebase on top of main branch now ? Operator sdk should not be an issue now.

done

go.mod Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
go.mod Outdated
Comment on lines 20 to 24
k8s.io/apimachinery v0.27.2
k8s.io/client-go v0.27.2
k8s.io/api v0.27.2
k8s.io/apimachinery v0.27.2
k8s.io/client-go v0.27.2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check for duplicate entries.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done, and also squashed into single commits

@subhamkrai subhamkrai force-pushed the update-k8s-version branch from aa93244 to 083fd94 Compare June 26, 2023 08:39
@subhamkrai subhamkrai requested a review from Madhu-1 June 26, 2023 09:03
Copy link
Member

@Rakshith-R Rakshith-R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a nit,
everything else looks good to me.

sidecar/internal/csiaddonsnode/csiaddonsnode.go Outdated Show resolved Hide resolved
@subhamkrai subhamkrai force-pushed the update-k8s-version branch from 083fd94 to 7eb2b08 Compare June 26, 2023 09:07
@subhamkrai subhamkrai requested a review from Rakshith-R June 26, 2023 09:08
@subhamkrai subhamkrai force-pushed the update-k8s-version branch from 7eb2b08 to 9aa14f0 Compare June 26, 2023 09:12
Madhu-1
Madhu-1 previously approved these changes Jun 26, 2023
this commit update the kubernetes pkgs to latest 0.27.2
and controller runtime version to 1.15.0.

Signed-off-by: subhamkrai <[email protected]>

Signed-off-by: subhamkrai <[email protected]>
@subhamkrai subhamkrai force-pushed the update-k8s-version branch from 9aa14f0 to e7f8958 Compare June 26, 2023 09:32
@mergify mergify bot dismissed Madhu-1’s stale review June 26, 2023 09:33

Pull request has been modified.

@Rakshith-R Rakshith-R requested a review from Madhu-1 June 26, 2023 09:47
@mergify mergify bot merged commit d4463a0 into csi-addons:main Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vendor Pull requests that update vendored dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants