NetworkFence: correct check in validating webhook #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a NetworkFence CR is validated, an incorrect comparison is done. `DeepEqual()` returns `true` when the there are no changes, this is valid and not an error. Adding `!` to inverse the check corrects the comparison and only reports an error when the parameters are modified. See-also: https://bugzilla.redhat.com/2182375 Signed-off-by: Niels de Vos <[email protected]>
Madhu-1
approved these changes
Mar 28, 2023
Rakshith-R
approved these changes
Mar 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a NetworkFence CR is validated, an incorrect comparison is done.
DeepEqual()returnstruewhen the there are no changes, this is valid and not an error. Adding!to inverse the check corrects the comparison and only reports an error when the parameters are modified.See-also: https://bugzilla.redhat.com/2182375