reclaimspace: consider VA object only it is attached & not being deleted #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit makes modification to ignore Volume Attachment objects which are being deleted or not attached. Signed-off-by: Rakshith R <[email protected]>
Madhu-1
reviewed
Jan 2, 2023
| @@ -324,7 +324,7 @@ func (r *ReclaimSpaceJobReconciler) getTargetDetails( | |||
| pvName: pv.Name, | |||
| } | |||
| for _, v := range volumeAttachments.Items { | |||
| if *v.Spec.Source.PersistentVolumeName == pv.Name { | |||
| if v.DeletionTimestamp.IsZero() && v.Status.Attached && *v.Spec.Source.PersistentVolumeName == pv.Name { | |||
There was a problem hiding this comment.
This is not true for controller space reclaim, as PV is not required to be attached, right?
There was a problem hiding this comment.
This is not true for controller space reclaim, as PV is not required to be attached, right?
We don't need node information for performing controller space reclaim.
It will still happen.
Madhu-1
approved these changes
Jan 2, 2023
yati1998
approved these changes
Jan 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes modification to ignore Volume Attachment objects which are being deleted or not attached.
Signed-off-by: Rakshith R [email protected]